[maintenance] deprecation fix, inference fix, and compat update #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The broken test was somehow introduced by ImageTransformations v0.8.10, which fixed #77 (Or maybe by ImageTransformations v0.8.9) |
Without much time investigating the root issue, I just: - update the reference (The differences are very small) - fix a random seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
permuteddimsview->PermutedDimsArray(deprecate permuteddimsview JuliaImages/ImageCore.jl#122)MappedArrayin newer Julia versionsIt's quite interesting that there comes a new broken test not being caught, I cannot yet identify where the root is, so I marked it as
@test_broken.closes #75
closes #76
closes #78
closes #79
closes #81