Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RCropSize() - Function for generating random crops of fixed size #64

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

maxfreu
Copy link
Contributor

@maxfreu maxfreu commented Jun 29, 2020

Hi, I couldn't find a function to generate random crops of fixed size from a larger image, so I wrote one. If this was already possible this might be a bit embarrassing, because I didn't find out how - but anyway; it now works like a charm, including tests :-)

using ImageView, Augmentor
img = testimage()
pl = RCropSize(100)
imshow(augment(img, pl))

EDIT: Local test all pass - the failing tests are hopefully unrelated.

@johnnychen94
Copy link
Collaborator

johnnychen94 commented Jun 29, 2020

Wow, nice! You're correct that this isn't available; there's also a plan #21 for this.

The failure isn't your fault, it's just that this package doesn't get fairly maintained. I'll come and fix that later this week and then get this PR in.

Edit: I may need another week to catch up with the work here.

@johnnychen94 johnnychen94 self-assigned this Jun 30, 2020
@maxfreu
Copy link
Contributor Author

maxfreu commented Aug 17, 2020

Ping :)

@johnnychen94
Copy link
Collaborator

Let me see if all things pass with #66

@johnnychen94 johnnychen94 merged commit 30b0d75 into Evizero:master Aug 25, 2020
@johnnychen94
Copy link
Collaborator

johnnychen94 commented Aug 25, 2020

Sorry for the long delay, I was too busy with my school work to fix things here. A very nice implementation and I like the test here. @maxfreu Thanks!

I just tagged a release (v0.6.1) for this PR. I'll add this into docs later in #52

@maxfreu
Copy link
Contributor Author

maxfreu commented Aug 25, 2020

Hey, cool to see this merged, thanks for the effort! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants