Use of_eltype instead of convert lambda
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @timholy in Evizero#17, this commit changes `mappedarray(c->convert(T,c), img)` to `of_eltype(T, img)`. It results into `MappedArray` instead of `ReadonlyMappedArray`, and it is more descriptive too. This commit does not deal with Evizero#17, but I can confirm that the issue seems to be fixed already (which @johnnychen94 noticed before) and can be closed: ```julia julia> using Augmentor, Test julia> img = testpattern(); julia> @inferred(augment(img, ConvertEltype(Gray))) |> summary # Gray{Any} "300×400 Array{Gray,2} with eltype Gray" julia> pl = SplitChannels() |> ConvertEltype(Gray) 2-step Augmentor.ImmutablePipeline: 1.) Split colorant into its color channels 2.) Convert eltype to Gray julia> @inferred(augment(img, pl)) |> summary # Gray{N0f8} "4×300×400 Array{Gray{N0f8},3} with eltype Gray{FixedPointNumbers.N0f8}" ```
johnnychen94
reviewed
Aug 9, 2021
johnnychen94
approved these changes
Aug 9, 2021
|
Tests passed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @timholy in #17, this PR changes
mappedarray(c->convert(T,c), img)toof_eltype(T, img). It resultsin
MappedArrayinstead ofReadonlyMappedArray, and it is more descriptive too.This PR does not deal with #17, but I can confirm that the issue seems to be fixed already (which @johnnychen94 noticed before) and can be closed: