-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make pipeline cleaner #33
Conversation
|
||
return nothing # skip current test case | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# File exists: |
Nice, good improvement. |
Mind to merge this? I'd like to open a new PR based on this so that it's easier to be reviewed. |
I stand by my above comments re breaking it into more functions. |
Ahh, yes, but I have"better" ideas than simply breaking it into parts, and that would change the code structure. |
Or I could push commits into this branch if you like. |
Ok lets merge this first. |
The first commit flattens the nested code structure by removing the
try-catch
block. There're no function changes except usingisfile
to check if reference file exists. (Is there any special reason usingtry-catch
here?)