New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ulysis #293
Ulysis #293
Conversation
…CMDDU2 handles the powerset of these features
…ed, 9 feature set
… - dist_one_hot_vec_mean
… - dist_one_hot_vec_mean
…erage*FF4, file location of the prior file must be stored in environmental variable PRIOR_LOC
Thanks @prantikchatterjee. I will review it as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prantikchatterjee, I've just reviewed your pull request and there are few things you must to address. But first, this pull request has a couple conflicts that must be resolved!
client/src/main/java/org/evosuite/TestSuiteGeneratorHelper.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/evosuite/TestSuiteGeneratorHelper.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/evosuite/statistics/RuntimeVariable.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/evosuite/statistics/RuntimeVariable.java
Outdated
Show resolved
Hide resolved
Just to let you know I've updated your branch (cfworld), fixed a few compilation issues, and removed some non-related changes. Now, I need you to review the following files and remove any code that isn't related to this pull request, e.g., code that you added at some point for some reason but it is no longer required. If you think some of these files are not required, please remove them.
-- |
Hi prantikchatterjee, I've just pulled the latest version of EvoSuite and now the cfworld branch does not compile. :-/ -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your pull request does now look good to me. However, one thing that it's still missing is a few test cases (both unit and system tests) to validate/exercise your new fitness functions. Any change you could add those? (In case you need help or inspiration on how to write those tests, I would recommend you the src/test/java
in the client module for unit tests and the src/test/java
in the master module for system tests).
--
Best,
Jose
Pull Request for Adding Ulysis to Evosuite