Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ulysis #293

Closed
wants to merge 83 commits into from
Closed

Ulysis #293

wants to merge 83 commits into from

Conversation

prantikchatterjee
Copy link

Pull Request for Adding Ulysis to Evosuite

prantik and others added 30 commits February 9, 2019 16:29
…CMDDU2 handles the powerset of these features
…erage*FF4, file location of the prior file must be stored in environmental variable PRIOR_LOC
@prantikchatterjee prantikchatterjee marked this pull request as ready for review April 26, 2020 17:51
@jose jose self-assigned this Apr 26, 2020
@jose jose self-requested a review April 26, 2020 18:29
@jose
Copy link
Member

jose commented Apr 26, 2020

Thanks @prantikchatterjee. I will review it as soon as possible.

Copy link
Member

@jose jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prantikchatterjee, I've just reviewed your pull request and there are few things you must to address. But first, this pull request has a couple conflicts that must be resolved!

client/src/main/java/org/evosuite/Properties.java Outdated Show resolved Hide resolved
client/src/main/java/org/evosuite/Properties.java Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jose
Copy link
Member

jose commented May 11, 2020

Hi @prantikchatterjee,

Just to let you know I've updated your branch (cfworld), fixed a few compilation issues, and removed some non-related changes.

Now, I need you to review the following files and remove any code that isn't related to this pull request, e.g., code that you added at some point for some reason but it is no longer required. If you think some of these files are not required, please remove them.

  • client/src/main/java/org/evosuite/coverage/aes/AbstractAESCoverageSuiteFitness.java
  • client/src/main/java/org/evosuite/coverage/aes/Spectrum.java
  • client/src/main/java/org/evosuite/coverage/aes/branch/AESBranchCoverageFactory.java
  • client/src/main/java/org/evosuite/coverage/aes/branch/AESBranchCoverageSuiteFitness.java
  • client/src/main/java/org/evosuite/coverage/aes/branch/UnreachableBranchCoverageTestFitness.java
  • client/src/main/java/org/evosuite/coverage/aes/method/AESMethodCoverageFactory.java
  • client/src/main/java/org/evosuite/coverage/aes/method/AESMethodCoverageSuiteFitness.java
  • client/src/main/java/org/evosuite/coverage/aes/method/AESPublicMethodCoverageSuiteFitness.java
  • client/src/main/java/org/evosuite/coverage/aes/method/UnreachableMethodCoverageTestFitness.java

--
Best,
Jose

@jose
Copy link
Member

jose commented Oct 17, 2020

Hi prantikchatterjee,

I've just pulled the latest version of EvoSuite and now the cfworld branch does not compile. :-/
Could you please have a look and fix the compilation issues? Thanks in advance.

--
Best,
Jose

Copy link
Member

@jose jose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prantikchatterjee,

Your pull request does now look good to me. However, one thing that it's still missing is a few test cases (both unit and system tests) to validate/exercise your new fitness functions. Any change you could add those? (In case you need help or inspiration on how to write those tests, I would recommend you the src/test/java in the client module for unit tests and the src/test/java in the master module for system tests).

--
Best,
Jose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants