Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new typing system #42

Merged
merged 1 commit into from Aug 25, 2019
Merged

Added new typing system #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -6,6 +6,7 @@ node_modules/
dist/
coverage/
yarn.lock
.rpt2_cache/
!.vscode/settings.json
!.vscode/tasks.json
!.vscode/launch.json
Expand Down
4 changes: 3 additions & 1 deletion .npmignore
View file
Open in desktop
Expand Up @@ -11,4 +11,6 @@ test-setup.js
test-shim.js
tsconfig.json
tslint.json
webpack.config.js
webpack.config.js
index.html
.rpt2_cache/
37 changes: 35 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
@@ -1,8 +1,9 @@
{
"name": "react-smart-tabs",
"version": "0.1.0",
"version": "0.2.5-alpha",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this jump?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weren't you guys using npm version on master for publishing? 🤦‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, created #45 for dealing with this later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the thing here is I tested 4 "failed alpha releases" attempting to get types coming inside the npm package (and proper set up)

"description": "A tab component with drag and drop functionality, add and close",
"main": "dist/bundle.js",
"types": "dist/components/index.d.ts",
"scripts": {
"test": "jest",
"dev": "webpack-dev-server --content-base ./dist --host 0.0.0.0 --hot --inline --colors --port 3000 --open",
Expand Down Expand Up @@ -59,10 +60,11 @@
"react-dom": "^16.9.0",
"react-svg": "^10.0.17",
"rollup-plugin-terser": "^5.1.1",
"rollup-plugin-typescript2": "^0.22.1",
"sass-loader": "^7.1.0",
"style-loader": "^0.23.1",
"tslint": "^5.18.0",
"url-loader": "^2.1.0",
"uuid": "^3.3.2"
}
}
}
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
@@ -1,4 +1,4 @@
import typescript from 'rollup-plugin-typescript';
import typescript from 'rollup-plugin-typescript2';
import scss from 'rollup-plugin-scss';
import {terser} from "rollup-plugin-terser";
import svg from 'rollup-plugin-svg'
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Expand Up @@ -4,7 +4,8 @@
"sourceMap": true,
"skipLibCheck": true,
"noImplicitAny": true,
"module": "commonjs",
"module": "ESNext",
"declaration": true,
"target": "es6",
"jsx": "react",
"esModuleInterop": true
Expand Down