Added null-value handling for script arguments and updated properties #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null values in script arguments can be handled in different ways. The handling can be configured by the option handleNullValues with the values asGone (default value) and asEmptyString.
|
@semancik What do you think about this? |
|
Looks good. Thanks for the contribution. Also, thanks for fixing Messages.properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null values in script arguments can be handled in different ways. The handling can be configured by the option
handleNullValueswith the valuesasGone(default value) andasEmptyString. This allows the user to choose, if the argument should bee completely removed, or be inserted as empty string.Also the display texts and descriptions for the different configuration properties were updated to match the existing ones.
Previously the connector threw a NullPointerException if the value of a script argument was null. This prevented the scripts from accepting empty values.