fix MID-3861 GUI Credentials - Attempt to encrypt protected data that…

… are already encrypted
Evolveum · Apr 24, 2017 · 00c8630 · 00c8630
1 parent 7ec0bd4
commit 00c8630
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 9 deletions.
diff --git a/...in-gui/src/main/java/com/evolveum/midpoint/web/page/self/PageAbstractSelfCredentials.java b/...in-gui/src/main/java/com/evolveum/midpoint/web/page/self/PageAbstractSelfCredentials.java
@@ -20,6 +20,7 @@
 import java.util.Collections;
 import java.util.List;
 
+import com.evolveum.prism.xml.ns._public.types_3.EncryptedDataType;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.wicket.ajax.AjaxRequestTarget;
 import org.apache.wicket.extensions.markup.html.tabs.AbstractTab;
@@ -57,6 +58,7 @@
 import com.evolveum.midpoint.web.security.SecurityUtils;
 import com.evolveum.midpoint.xml.ns._public.common.common_3.*;
 import com.evolveum.prism.xml.ns._public.types_3.ProtectedStringType;
+import org.apache.xml.security.encryption.EncryptedData;
 
 /**
  * @author Viliam Repan (lazyman)
@@ -320,8 +322,9 @@ protected void onSavePerformed(AjaxRequestTarget target) {
         try {
             MyPasswordsDto dto = model.getObject();
             ProtectedStringType password = dto.getPassword();
-            WebComponentUtil.encryptProtectedString(password, true, getMidpointApplication());
-
+            if (!password.isEncrypted()) {
+                WebComponentUtil.encryptProtectedString(password, true, getMidpointApplication());
+            }
             final ItemPath valuePath = new ItemPath(SchemaConstantsGenerated.C_CREDENTIALS,
                     CredentialsType.F_PASSWORD, PasswordType.F_VALUE);
             SchemaRegistry registry = getPrismContext().getSchemaRegistry();
@@ -343,11 +346,7 @@ protected void onSavePerformed(AjaxRequestTarget target) {
 
             result.computeStatus();
         } catch (Exception ex) {
-            MyPasswordsDto dto = model.getObject();
-            ProtectedStringType password = dto.getPassword();
-            if (password != null){
-                password.setEncryptedData(null);
-            }
+            setEncryptedPasswordData(null);
             LoggingUtils.logUnexpectedException(LOGGER, "Couldn't save password changes", ex);
             result.recordFatalError(getString("PageAbstractSelfCredentials.save.password.failed", ex.getMessage()), ex);
         } finally {
@@ -356,6 +355,14 @@ protected void onSavePerformed(AjaxRequestTarget target) {
 
         finishChangePassword(result, target);
     }
+
+    protected void setEncryptedPasswordData(EncryptedDataType data){
+        MyPasswordsDto dto = model.getObject();
+        ProtectedStringType password = dto.getPassword();
+        if (password != null){
+            password.setEncryptedData(data);
+        }
+    }
 
     protected abstract boolean isCheckOldPassword();
 

diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/self/PageSelfCredentials.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/self/PageSelfCredentials.java
@@ -30,11 +30,11 @@ protected boolean isCheckOldPassword() {
 	@Override
 	protected void finishChangePassword(OperationResult result, AjaxRequestTarget target) {
 		if (!WebComponentUtil.isSuccessOrHandledError(result)) {
+			setEncryptedPasswordData(null);
             showResult(result);
             target.add(getFeedbackPanel());
         } else {
-            showResult(result);
-
+			showResult(result);
             setResponsePage(getMidpointApplication().getHomePage());
         }
 	}