Skip to content

Commit

Permalink
POM fixes after master merge, fixed falsely reported used tomcat
Browse files Browse the repository at this point in the history
  • Loading branch information
virgo47 committed Apr 9, 2020
1 parent b151b7d commit 0588378
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
5 changes: 0 additions & 5 deletions gui/admin-gui/pom.xml
Expand Up @@ -357,11 +357,6 @@
<version>${project.version}</version>
</dependency>

<dependency> <!-- needed as runtime dependency otherwise spring won't start -->
<groupId>org.springframework</groupId>
<artifactId>spring-aspects</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>org.codehaus.groovy</groupId>
<artifactId>groovy-all</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions model/rest-impl/pom.xml
Expand Up @@ -55,10 +55,6 @@
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
</dependency>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-web</artifactId>
Expand Down
4 changes: 4 additions & 0 deletions pom.xml
Expand Up @@ -1768,6 +1768,7 @@
<ignoredUsedUndeclaredDependency>org.slf4j:jcl-over-slf4j</ignoredUsedUndeclaredDependency>
<ignoredUsedUndeclaredDependency>org.slf4j:slf4j-api</ignoredUsedUndeclaredDependency>
<ignoredUsedUndeclaredDependency>org.danekja:jdk-serializable-functional</ignoredUsedUndeclaredDependency>
<ignoredUsedUndeclaredDependency>org.apache.tomcat.embed:tomcat-embed-core</ignoredUsedUndeclaredDependency>
</ignoredUsedUndeclaredDependencies>
</configuration>
</execution>
Expand All @@ -1782,7 +1783,9 @@
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${checkstyle.version}</version>
<configuration>
<!--suppress MavenModelInspection: provided by mvn(w)/IDE/Jenkins -->
<configLocation>${maven.multiModuleProjectDirectory}/config/checkstyle/checkstyle.xml</configLocation>
<!--suppress MavenModelInspection: provided by mvn(w)/IDE/Jenkins -->
<suppressionsLocation>${maven.multiModuleProjectDirectory}/config/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
<encoding>UTF-8</encoding>
<consoleOutput>true</consoleOutput>
Expand Down Expand Up @@ -2025,6 +2028,7 @@
<!-- TODO: unify with other checkstyle setup in pluginManagement? -->
<version>${checkstyle.version}</version>
<configuration>
<!--suppress MavenModelInspection: provided by mvn(w)/IDE/Jenkins -->
<configLocation>${maven.multiModuleProjectDirectory}/build-system/checkstyle-configs/checkstyle.xml</configLocation>
<!-- TODO: what about suppressions? without them and with failsOnError true it must fail, or not? -->
<encoding>UTF-8</encoding>
Expand Down

0 comments on commit 0588378

Please sign in to comment.