removed isAddNewObjectMenuItemAuthorized check during menu items crea…

…ting, authorization check is already implemented with #{page}Details authorization
Evolveum · Sep 7, 2022 · 14dfb64 · 14dfb64
1 parent 5405704
commit 14dfb64
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 23 deletions.
diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/component/menu/LeftMenuPanel.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/component/menu/LeftMenuPanel.java
@@ -484,11 +484,9 @@ private void createFocusPageNewEditMenu(MainMenuItem mainMenuItem, String newKey
             final Class<? extends PageBase> newPageClass) {
 
         boolean addActive = classMatches(newPageClass) && !isEditForAdminObjectDetails() && !isEditForResourceWizzard();
-        if (isAddNewObjectMenuItemAuthorized(newPageClass)) {       //mid-7145
-            MenuItem newMenu = new MenuItem(newKey,
-                    GuiStyleConstants.CLASS_PLUS_CIRCLE, newPageClass, null, addActive);
-            mainMenuItem.addMenuItem(newMenu);
-        }
+        MenuItem newMenu = new MenuItem(newKey,
+                GuiStyleConstants.CLASS_PLUS_CIRCLE, newPageClass, null, addActive);
+        mainMenuItem.addMenuItem(newMenu);
 
         boolean editActive = classMatches(newPageClass) && (isEditForAdminObjectDetails() || isEditForResourceWizzard());
         if (editActive) {
@@ -497,20 +495,6 @@ private void createFocusPageNewEditMenu(MainMenuItem mainMenuItem, String newKey
         }
     }
 
-    private <AH extends AssignmentHolderType> boolean isAddNewObjectMenuItemAuthorized(Class<? extends PageBase> newPageClass) {
-        if (PageAssignmentHolderDetails.class.isAssignableFrom(newPageClass)) {
-            try {
-                PageAssignmentHolderDetails<AH, ?> page = (PageAssignmentHolderDetails<AH, ?>) newPageClass.getConstructor().newInstance();
-                PrismObject<AH> object = getPrismContext().createObject(page.getType());
-                return getPageBase().isAuthorized(ModelAuthorizationAction.ADD.getUrl(),
-                        AuthorizationPhaseType.REQUEST, object, null, null, null);
-            } catch (Exception ex) {
-                LoggingUtils.logUnexpectedException(LOGGER, "Couldn't solve authorization for New object menu item", ex);
-            }
-        }
-        return true;
-    }
-
     private boolean classMatches(Class<? extends PageBase> page) {
         return getPageBase().getClass().equals(page);
     }

diff --git a/...in-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/admin/resource/PageResource.java b/...in-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/admin/resource/PageResource.java
@@ -42,10 +42,6 @@
         })
 public class PageResource extends PageAssignmentHolderDetails<ResourceType, ResourceDetailsModel> {
 
-    public PageResource()  {
-        super();
-    }
-
     public PageResource(PageParameters pageParameters) {
         super(pageParameters);
     }