Skip to content

Commit

Permalink
Merge branch 'master' of github.com:Evolveum/midpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
1azyman committed Sep 7, 2023
2 parents e69b755 + 5edf010 commit 15a0ae7
Show file tree
Hide file tree
Showing 6 changed files with 38 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,37 @@
*/
package com.evolveum.midpoint.gui.api.component.autocomplete;

import com.evolveum.midpoint.gui.api.page.PageBase;
import com.evolveum.midpoint.gui.api.util.WebComponentUtil;
import com.evolveum.midpoint.xml.ns._public.common.common_3.LookupTableType;

import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.model.IModel;
import org.apache.wicket.util.convert.IConverter;

public class LookupTableLabelPanel extends Label {

private final String lookupTableOid;

public LookupTableLabelPanel(String id, IModel<?> model) {
public LookupTableLabelPanel(String id, IModel<?> model, String lookupTableOid) {
super(id, model);
this.lookupTableOid = lookupTableOid;
}

@Override
public <C> IConverter<C> getConverter(Class<C> type) {
return new LookupTableConverter<C>(super.getConverter(type), this, true);
return new LookupTableConverter<C>(super.getConverter(type), this, true){
@Override
protected LookupTableType getLookupTable() {
if (lookupTableOid != null) {
return WebComponentUtil.loadLookupTable(lookupTableOid, getPageBase());
}
return null;
}
};
}

public PageBase getPageBase() {
return (PageBase) getPage();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,16 @@
*/
package com.evolveum.midpoint.gui.impl.factory.panel;

import com.evolveum.midpoint.gui.api.prism.wrapper.PrismValueWrapper;

import jakarta.annotation.PostConstruct;

import com.evolveum.midpoint.gui.api.component.autocomplete.LookupTableLabelPanel;

import org.apache.wicket.behavior.AttributeAppender;
import org.apache.wicket.markup.html.basic.Label;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;

import com.evolveum.midpoint.gui.api.component.autocomplete.LookupTableLabelPanel;
import com.evolveum.midpoint.gui.api.factory.GuiComponentFactory;
import com.evolveum.midpoint.gui.api.prism.wrapper.ItemWrapper;
import com.evolveum.midpoint.gui.api.prism.wrapper.PrismPropertyWrapper;
import com.evolveum.midpoint.gui.api.prism.wrapper.PrismValueWrapper;
import com.evolveum.midpoint.gui.api.registry.GuiComponentRegistry;

@Component
Expand All @@ -41,7 +37,7 @@ public void register() {
public org.apache.wicket.Component createPanel(PrismPropertyPanelContext<T> panelCtx) {
String lookupTableOid = panelCtx.getPredefinedValuesOid();
if (lookupTableOid != null) {
return new LookupTableLabelPanel(panelCtx.getComponentId(), panelCtx.getRealValueStringModel());
return new LookupTableLabelPanel(panelCtx.getComponentId(), panelCtx.getRealValueStringModel(), lookupTableOid);
}
return new Label(panelCtx.getComponentId(), panelCtx.getRealValueStringModel());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@
<form wicket:id="mainForm" class="form-horizontal">
<div wicket:id="changePasswordPanel"/>
</form>
<a class="text-center login-panel-control mt-2" style="display: inline-block;" wicket:id="back">
<i class="fas fa-arrow-left mr-2"></i>
<wicket:message key="PageEmailNonce.backButtonLabel"/>
</a>
</wicket:extend>

</body>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public class PageResetPassword extends AbstractPageLogin {
protected static final String ID_MAIN_FORM = "mainForm";
private static final String ID_CHANGE_PASSWORD_PANEL = "changePasswordPanel";
private static final String CHANGE_PASSWORD_BUTTON_STYLE = "btn btn-primary login-panel-control";
private static final String ID_BACK_BUTTON = "back";

public PageResetPassword() {
super();
Expand Down Expand Up @@ -133,16 +132,6 @@ protected String getChangePasswordButtonStyle() {
};
changePasswordPanel.setOutputMarkupId(true);
form.add(changePasswordPanel);
AjaxButton backButton = new AjaxButton(ID_BACK_BUTTON) {
@Serial private static final long serialVersionUID = 1L;

@Override
public void onClick(AjaxRequestTarget target) {
cancelPerformed();
}
};
backButton.setOutputMarkupId(true);
add(backButton);

}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
package com.evolveum.midpoint.gui.impl.page.login.module;

import java.io.Serial;

import com.evolveum.midpoint.gui.api.component.result.Toast;
import com.evolveum.midpoint.web.page.error.PageError;

import org.apache.wicket.RestartResponseException;
Expand Down Expand Up @@ -62,7 +64,7 @@ public PageEmailNonce() {
// TODO improve message with the time when the mail was sent (saved in nonce metadata)

if (!alreadyHasNonce()) {
generateAndSendNonce();
generateAndSendNonce(null);
}

LOGGER.debug("Nonce won't be generated automatically, user already has one.");
Expand Down Expand Up @@ -93,16 +95,15 @@ private void initButtons(MidpointForm form) {

@Override
public void onClick(AjaxRequestTarget target) {
generateAndSendNonce();
//TODO toast with success message.
generateAndSendNonce(target);
}

};
form.add(resendNonce);
}


private void generateAndSendNonce() {
private void generateAndSendNonce(AjaxRequestTarget target) {
UserType user = searchUser();
validateUserNotNullOrFail(user);
LOGGER.trace("Reset Password user: {}", user);
Expand All @@ -112,6 +113,15 @@ private void generateAndSendNonce() {
OperationResult result = saveUserNonce(user, noncePolicy);
if (result.getStatus() != OperationResultStatus.SUCCESS) {
LOGGER.error("Failed to send nonce to user: {} ", result.getMessage());
} else if (target != null) {
new Toast()
.success()
.title(getString("PageEmailNonce.sentNonce"))
.icon("fas fa-circle-check")
.autohide(true)
.delay(5_000)
.body(getString("PageEmailNonce.sentNonce.message"))
.show(target);
}

}
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
<version>3.0.6</version>
<version>3.0.10</version>
<!-- This parent also declares dependencies listed here:
https://docs.spring.io/spring-boot/docs/2.7.3/reference/html/dependency-versions.html#dependency-versions
Or for current version of Spring Boot:
Expand Down

0 comments on commit 15a0ae7

Please sign in to comment.