new assignment button visibility fix

Evolveum · Jan 17, 2020 · 2656675 · 2656675
1 parent 1a4277f
commit 2656675
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 22 deletions.
diff --git a/.../src/main/java/com/evolveum/midpoint/gui/impl/component/MultivalueContainerListPanel.java b/.../src/main/java/com/evolveum/midpoint/gui/impl/component/MultivalueContainerListPanel.java
@@ -287,7 +287,7 @@ protected void buttonClickPerformed(AjaxRequestTarget target, AssignmentObjectRe
                     }
 
                     @Override
-                    protected boolean isMainButtonVisible(){
+                    protected boolean isDefaultButtonVisible(){
                         return getNewObjectGenericButtonVisibility();
                     }
 

diff --git a/...min-gui/src/main/java/com/evolveum/midpoint/web/component/MultiCompositedButtonPanel.java b/...min-gui/src/main/java/com/evolveum/midpoint/web/component/MultiCompositedButtonPanel.java
@@ -44,7 +44,6 @@ private void initLayout(){
         DisplayType defaultObjectButtonDisplayType = fixDisplayTypeIfNeeded(getDefaultObjectButtonDisplayType());
         DisplayType mainButtonDisplayType = fixDisplayTypeIfNeeded(getMainButtonDisplayType());
         RepeatingView buttonsPanel = new RepeatingView(ID_BUTTON_PANEL);
-        buttonsPanel.add(new VisibleBehaviour(() -> additionalButtonsExist()));
         add(buttonsPanel);
 
         if (additionalButtonsExist()){
@@ -65,27 +64,27 @@ public void onClick(AjaxRequestTarget target) {
                 additionalButton.add(AttributeAppender.append("class", DEFAULT_BUTTON_STYLE));
                 buttonsPanel.add(additionalButton);
             });
+        }
+        //we set main button icon class if no other is defined
+        if (StringUtils.isEmpty(defaultObjectButtonDisplayType.getIcon().getCssClass())) {
+            defaultObjectButtonDisplayType.getIcon().setCssClass(mainButtonDisplayType.getIcon().getCssClass());
+        }
 
-            //we set main button icon class if no other is defined
-            if (StringUtils.isEmpty(defaultObjectButtonDisplayType.getIcon().getCssClass())){
-                defaultObjectButtonDisplayType.getIcon().setCssClass(mainButtonDisplayType.getIcon().getCssClass());
-            }
+        AjaxCompositedIconButton defaultButton = new AjaxCompositedIconButton(buttonsPanel.newChildId(),
+                getAdditionalIconBuilder(defaultObjectButtonDisplayType).build(),
+                Model.of(WebComponentUtil.getDisplayTypeTitle(defaultObjectButtonDisplayType))) {
 
-            AjaxCompositedIconButton defaultButton = new AjaxCompositedIconButton(buttonsPanel.newChildId(),
-                    getAdditionalIconBuilder(defaultObjectButtonDisplayType).build(),
-                    Model.of(WebComponentUtil.getDisplayTypeTitle(defaultObjectButtonDisplayType))){
+            private static final long serialVersionUID = 1L;
 
-                private static final long serialVersionUID = 1L;
+            @Override
+            public void onClick(AjaxRequestTarget target) {
+                buttonClickPerformed(target, null, null);
+            }
+        };
+        defaultButton.add(AttributeAppender.append("class", DEFAULT_BUTTON_STYLE));
+        defaultButton.add(new VisibleBehaviour(this::isDefaultButtonVisible));
+        buttonsPanel.add(defaultButton);
 
-                @Override
-                public void onClick(AjaxRequestTarget target) {
-                    buttonClickPerformed(target, null, null);
-                }
-            };
-            defaultButton.add(AttributeAppender.append("class", DEFAULT_BUTTON_STYLE));
-            defaultButton.add(new VisibleBehaviour(this::isMainButtonVisible));
-            buttonsPanel.add(defaultButton);
-        }
     }
 
     private CompositedIcon getCompositedIcon(MultiFunctinalButtonDto additionalButtonObject) {
@@ -131,11 +130,11 @@ private DisplayType fixDisplayTypeIfNeeded(DisplayType displayType){
     protected void buttonClickPerformed(AjaxRequestTarget target, AssignmentObjectRelation relationSepc, CompiledObjectCollectionView collectionViews){
     }
 
-    private boolean additionalButtonsExist() {
+    protected boolean additionalButtonsExist() {
         return CollectionUtils.isNotEmpty(buttonDtos);
     }
 
-    protected boolean isMainButtonVisible(){
+    protected boolean isDefaultButtonVisible(){
         return true;
     }
 }
diff --git a/...min-gui/src/main/java/com/evolveum/midpoint/web/component/assignment/AssignmentPanel.java b/...min-gui/src/main/java/com/evolveum/midpoint/web/component/assignment/AssignmentPanel.java
@@ -155,6 +155,7 @@ protected void newItemPerformed(AjaxRequestTarget target, AssignmentObjectRelati
 
                     @Override
                     protected List<MultiFunctinalButtonDto> createNewButtonDescription() {
+                        List<MultiFunctinalButtonDto> buttonDtoList = new ArrayList<>();
                         if (AssignmentPanel.this.getModelObject() == null) {
                             return null;
                         }
@@ -168,7 +169,6 @@ protected List<MultiFunctinalButtonDto> createNewButtonDescription() {
                             return null;
                         }
 
-                        List<MultiFunctinalButtonDto> buttonDtoList = new ArrayList<>();
 
                         relations.forEach(relation -> {
                             MultiFunctinalButtonDto buttonDto = new MultiFunctinalButtonDto();