Axiom: Argument is now optional

Signed-off-by: Tony Tkacik <tonydamage@gmail.com>
Evolveum · May 13, 2020 · 272745a · 272745a
1 parent 4c0f8bd
commit 272745a
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 8 deletions.
diff --git a/infra/axiom/src/main/java/com/evolveum/axiom/lang/impl/BasicStatementRule.java b/infra/axiom/src/main/java/com/evolveum/axiom/lang/impl/BasicStatementRule.java
@@ -20,7 +20,7 @@ public enum BasicStatementRule implements StatementRule<AxiomIdentifier> {
         @Override
         public void apply(StatementRuleContext<AxiomIdentifier> rule) throws AxiomSemanticException {
             Optional<AxiomItemDefinition> argument = rule.typeDefinition().argument();
-            if(argument.isPresent()) {
+            if(argument.isPresent() && rule.optionalValue().isPresent()) {
                rule.apply(ctx -> ctx.createEffectiveChild(argument.get().name(), ctx.requireValue()));
             }
         }

diff --git a/infra/axiom/src/main/java/com/evolveum/axiom/lang/impl/StatementRuleContext.java b/infra/axiom/src/main/java/com/evolveum/axiom/lang/impl/StatementRuleContext.java
@@ -32,4 +32,6 @@ public interface Action<V> {
 
     AxiomTypeDefinition typeDefinition();
 
+    Optional<V> optionalValue();
+
 }
diff --git a/infra/axiom/src/main/java/com/evolveum/axiom/lang/impl/StatementRuleContextImpl.java b/infra/axiom/src/main/java/com/evolveum/axiom/lang/impl/StatementRuleContextImpl.java
@@ -99,6 +99,11 @@ public AxiomTypeDefinition typeDefinition() {
         return context.definition().type();
     }
 
+    @Override
+    public Optional<V> optionalValue() {
+        return context.optionalValue();
+    }
+
     @Override
     public RuleErrorMessage error(String format, Object... arguments) {
         return RuleErrorMessage.from(context.startLocation(), format, arguments);

diff --git a/infra/axiom/src/main/resources/axiom-lang.axiom b/infra/axiom/src/main/resources/axiom-lang.axiom
@@ -98,10 +98,5 @@ model axiom-lang {
         }
     }
 
-    type AxiomTypeReference {
-    //    extends AxiomReference;
-    //    item targetType {
-    //        value AxiomTypeDefinition;
-    //    }
-    }
+    type AxiomTypeReference;
 }
diff --git a/infra/axiom/src/test/resources/base-example.axiom b/infra/axiom/src/test/resources/base-example.axiom
@@ -14,9 +14,9 @@ model model-header {
     version "0.0.1";
 
     type string;
-    type PolyString;
     type Address;
     type Link;
+    type PolyString;
 
     type Example {
         documentation """
@@ -45,4 +45,9 @@ model model-header {
           maxOccurs unbounded;
         }
     }
+
+    object {
+        name User2;
+        itemName user;
+    }
 }