MID-8842 ninja - approval work items processor + test

(cherry picked from commit e7e59cc)
Evolveum · Jul 25, 2023 · 27ae970 · 27ae970
1 parent e2fc3c2
commit 27ae970
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 6 deletions.
diff --git a/...ain/java/com/evolveum/midpoint/schema/validator/processor/ApprovalWorkItemsProcessor.java b/...ain/java/com/evolveum/midpoint/schema/validator/processor/ApprovalWorkItemsProcessor.java
@@ -14,13 +14,14 @@
 import com.evolveum.midpoint.schema.validator.UpgradePriority;
 import com.evolveum.midpoint.schema.validator.UpgradeType;
 import com.evolveum.midpoint.xml.ns._public.common.common_3.AssignmentHolderType;
+import com.evolveum.midpoint.xml.ns._public.common.common_3.OtherPrivilegesLimitationType;
 
 @SuppressWarnings("unused")
 public class ApprovalWorkItemsProcessor implements UpgradeObjectProcessor<AssignmentHolderType> {
 
     @Override
     public UpgradePhase getPhase() {
-        return UpgradePhase.AFTER;
+        return UpgradePhase.BEFORE;
     }
 
     @Override
@@ -35,13 +36,18 @@ public UpgradeType getType() {
 
     @Override
     public boolean isApplicable(PrismObject<?> object, ItemPath path) {
-        // todo implement
-        return false;
+        return matchParentTypeAndItemName(
+                object, path, OtherPrivilegesLimitationType.class, OtherPrivilegesLimitationType.F_APPROVAL_WORK_ITEMS);
     }
 
     @Override
     public boolean process(PrismObject<AssignmentHolderType> object, ItemPath path) {
-        // todo implement
-        return false;
+        OtherPrivilegesLimitationType limitation = getItemParent(object, path);
+        if (limitation.getCaseManagementWorkItems() == null) {
+            limitation.setCaseManagementWorkItems(limitation.getApprovalWorkItems());
+        }
+        limitation.setApprovalWorkItems(null);
+
+        return true;
     }
 }
diff --git a/...src/test/java/com/evolveum/midpoint/schema/validator/processor/TestUpgradeProcessors.java b/...src/test/java/com/evolveum/midpoint/schema/validator/processor/TestUpgradeProcessors.java
@@ -180,7 +180,7 @@ public void test30TestSystemConfig() throws Exception {
     @Test
     public void test40TestRole() throws Exception {
         testUpgradeValidator("role.xml", result -> {
-            Assertions.assertThat(result.getItems()).hasSize(1);
+            Assertions.assertThat(result.getItems()).hasSize(4);
 
             UpgradeValidationItem item = assertGetItem(result, getProcessorIdentifier(PersonaTargetSubtypeProcessor.class));
             UpgradeValidationItemAsserter asserter = new UpgradeValidationItemAsserter(item);

diff --git a/infra/schema/src/test/resources/validator/expected/role.xml b/infra/schema/src/test/resources/validator/expected/role.xml
@@ -17,4 +17,27 @@
         </personaConstruction>
     </assignment>
 
+    <assignment id="2">
+        <limitOtherPrivileges>
+            <caseManagementWorkItems>
+                <all>true</all>
+            </caseManagementWorkItems>
+        </limitOtherPrivileges>
+    </assignment>
+
+    <inducement id="3">
+        <limitOtherPrivileges>
+            <caseManagementWorkItems>
+                <all>true</all>
+            </caseManagementWorkItems>
+        </limitOtherPrivileges>
+    </inducement>
+
+    <inducement id="4">
+        <limitOtherPrivileges>
+            <caseManagementWorkItems>
+                <all>false</all>
+            </caseManagementWorkItems>
+        </limitOtherPrivileges>
+    </inducement>
 </role>
diff --git a/infra/schema/src/test/resources/validator/processor/role.xml b/infra/schema/src/test/resources/validator/processor/role.xml
@@ -17,4 +17,30 @@
         </personaConstruction>
     </assignment>
 
+    <assignment id="2">
+        <limitOtherPrivileges>
+            <approvalWorkItems>
+                <all>true</all>
+            </approvalWorkItems>
+        </limitOtherPrivileges>
+    </assignment>
+
+    <inducement id="3">
+        <limitOtherPrivileges>
+            <approvalWorkItems>
+                <all>true</all>
+            </approvalWorkItems>
+        </limitOtherPrivileges>
+    </inducement>
+
+    <inducement id="4">
+        <limitOtherPrivileges>
+            <approvalWorkItems>
+                <all>true</all>
+            </approvalWorkItems>
+            <caseManagementWorkItems>
+                <all>false</all>
+            </caseManagementWorkItems>
+        </limitOtherPrivileges>
+    </inducement>
 </role>