MID-7030: Fixed thread safety in AbstractLazy

Signed-off-by: Tony Tkacik <tonydamage@gmail.com>
Evolveum · May 3, 2021 · 296daf6 · 296daf6
1 parent 2c893ac
commit 296daf6
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/infra/axiom/src/main/java/com/evolveum/axiom/concepts/AbstractLazy.java b/infra/axiom/src/main/java/com/evolveum/axiom/concepts/AbstractLazy.java
@@ -8,20 +8,21 @@
 
 public abstract class AbstractLazy<T> {
 
-    private Object value;
+    private volatile Object value;
 
     AbstractLazy(Object supplier) {
         value = supplier;
     }
 
     T unwrap() {
-        if (value instanceof Lazy.Supplier<?>) {
+        Object val = this.value;
+        if (val instanceof Lazy.Supplier<?>) {
             //noinspection unchecked
-            value = ((Lazy.Supplier<T>) value).get();
+            this.value = ((Lazy.Supplier<T>) val).get();
             return unwrap();
         }
         //noinspection unchecked
-        return (T) value;
+        return (T) val;
     }
 
     @Override