secret providers: some small fix for caching

Evolveum · Feb 23, 2024 · 444df3b · 444df3b
1 parent 4c6ddc6
commit 444df3b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/infra/common/src/main/java/com/evolveum/midpoint/common/secrets/SecretsProviderImpl.java b/infra/common/src/main/java/com/evolveum/midpoint/common/secrets/SecretsProviderImpl.java
@@ -86,7 +86,7 @@ private <ST> ST getOrResolveSecret(String key, Class<ST> type) throws Encryption
         if (value != null) {
             LOGGER.trace("Cache hit for key {}", key);
 
-            if (Clock.get().currentTimeMillis() <= ttl) {
+            if (Clock.get().currentTimeMillis() - value.ttl <= ttl) {
                 LOGGER.trace("Cache entry for key {} is still valid, using cached value", key);
 
                 if (value.value == null) {
@@ -112,7 +112,7 @@ private <ST> ST getOrResolveSecret(String key, Class<ST> type) throws Encryption
 
         if (ttl > 0) {
             LOGGER.trace("Caching secret for key {}", key);
-            cache.put(key, new CacheValue<>(secret, System.currentTimeMillis() + ttl));
+            cache.put(key, new CacheValue<>(secret, Clock.get().currentTimeMillis() + ttl));
         }
 
         return secret;