Skip to content

Commit

Permalink
MID-8842 ninja - minor logging improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
1azyman committed Aug 14, 2023
1 parent 962317e commit 4948bae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public VerifyResult execute() throws Exception {
result = super.execute();
}

log.info("");
log.info(
"Verification finished. {}, {}, {} optional issues found",
ConsoleFormat.formatMessageWithErrorParameters("{} critical", result.getCriticalCount()),
Expand All @@ -82,16 +83,16 @@ public VerifyResult execute() throws Exception {
if (options.getOutput() != null) {
log.info("Verification report saved to '{}'", options.getOutput().getPath());


if (Objects.equals(VerifyOptions.ReportStyle.CSV, options.getReportStyle())) {
log.info("XML dump with delta for each item saved to '{}'", options.getOutput().getPath() + VerificationReporter.DELTA_FILE_NAME_SUFFIX);
}

// FIXME: ADD links (do not display in batch mode)
// FIXME: Could We could try to infer script name?
if (context.isUserMode()) {
log.info("");
log.info("Please see documentation for use of verification report in upgrade process and modify it accordingly.");
log.info("After you reviewed verification report and marked changes to skip you can continue upgrade process "
log.info("After you've reviewed verification report and marked changes to skip you can continue upgrade process "
+ "with running 'ninja.sh upgrade-objects --verification-file \"{}\"'", options.getOutput().getPath());
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,10 @@ protected void handleResultOnFinish(OperationStatus operation, String finishMess
super.handleResultOnFinish(operation, finishMessage);
OperationResult result = operation.getResult();
if (result.isAcceptable() && context.isUserMode()) {
log.info("");
log.info("Objects were successfully upgraded.");
log.info("If you want to continue to continue with upgrade, please run:"
+ "ninja.sh upgrade-distribution.");
log.info("");
log.info("If you want to continue to continue with upgrade, please run: ninja.sh upgrade-distribution.");
}
}
}

0 comments on commit 4948bae

Please sign in to comment.