Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix guessable work item ID weakness (MID-5291)
In addition to the work item number we expect and check SHA256 hash of some parts of the work item. The attacker does not know them, so he is unable to create/guess the respective URL.
- Loading branch information
Showing
3 changed files
with
89 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
.../src/main/java/com/evolveum/midpoint/web/page/admin/workflow/dto/ProtectedWorkItemId.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright (c) 2010-2019 Evolveum | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.evolveum.midpoint.web.page.admin.workflow.dto; | ||
|
|
||
| import com.evolveum.midpoint.prism.xml.XmlTypeConverter; | ||
| import com.evolveum.midpoint.schema.util.WfContextUtil; | ||
| import com.evolveum.midpoint.util.MiscUtil; | ||
| import com.evolveum.midpoint.util.exception.SystemException; | ||
| import com.evolveum.midpoint.xml.ns._public.common.common_3.WorkItemType; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| import java.nio.charset.StandardCharsets; | ||
| import java.security.MessageDigest; | ||
| import java.security.NoSuchAlgorithmException; | ||
|
|
||
| /** | ||
| * Protected version of work item ID in the form of "id:hash". | ||
| * | ||
| * It is to be used as part of URL used to display the work item. The hash is computed from selected parts of | ||
| * the work item so it is impossible to guess. | ||
| */ | ||
| public class ProtectedWorkItemId { | ||
|
|
||
| @NotNull public final String id; | ||
| @NotNull public final String hash; | ||
|
|
||
| private ProtectedWorkItemId(@NotNull String id, @NotNull String hash) { | ||
| this.id = id; | ||
| this.hash = hash; | ||
| } | ||
|
|
||
| public static ProtectedWorkItemId fromExternalForm(@NotNull String externalForm) { | ||
| int i = externalForm.indexOf(':'); | ||
| if (i < 0) { | ||
| throw new IllegalArgumentException("Wrong work item ID format"); | ||
| } | ||
| return new ProtectedWorkItemId(externalForm.substring(0, i), externalForm.substring(i+1)); | ||
| } | ||
|
|
||
| private static String createWorkItemHash(WorkItemType workItem) { | ||
| try { | ||
| String valueToHash = workItem.getExternalId() + ":" + | ||
| WfContextUtil.getTaskOid(workItem) + ":" + | ||
| XmlTypeConverter.toMillis(workItem.getCreateTimestamp()); | ||
| byte[] hashBytes = MessageDigest.getInstance("SHA-256").digest(valueToHash.getBytes(StandardCharsets.UTF_8)); | ||
| return MiscUtil.binaryToHex(hashBytes); | ||
| } catch (NoSuchAlgorithmException e) { | ||
| throw new SystemException("Couldn't compute message digest: " + e.getMessage(), e); | ||
| } | ||
| } | ||
|
|
||
| public static String createExternalForm(WorkItemType workItem) { | ||
| return workItem.getExternalId() + ":" + createWorkItemHash(workItem); | ||
| } | ||
|
|
||
| public boolean isCorrect(WorkItemType workItem) { | ||
| return hash.equals(createWorkItemHash(workItem)); | ||
| } | ||
| } |