Story test for existential issues (MID-4564)

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/lens/projector/ActivationProcessor.java

@@ -566,12 +566,12 @@ private <F extends FocusType> boolean evaluateExistenceMapping(final LensContext
 	        return false;
 		});
 
-        PrismPropertyDefinitionImpl<Boolean> shadowExistsDef = new PrismPropertyDefinitionImpl<>(
+        PrismPropertyDefinitionImpl<Boolean> shadowExistenceTargetDef = new PrismPropertyDefinitionImpl<>(
 				SHADOW_EXISTS_PROPERTY_NAME,
 				DOMUtil.XSD_BOOLEAN, prismContext);
-        shadowExistsDef.setMinOccurs(1);
-        shadowExistsDef.setMaxOccurs(1);
-        params.setTargetItemDefinition(shadowExistsDef);
+        shadowExistenceTargetDef.setMinOccurs(1);
+        shadowExistenceTargetDef.setMaxOccurs(1);
+        params.setTargetItemDefinition(shadowExistenceTargetDef);
 		mappingEvaluator.evaluateMappingSetProjection(params, task, result);
 
 		return (boolean) output.getValue();

model/model-intest/src/test/java/com/evolveum/midpoint/model/intest/TestActivation.java

@@ -2932,11 +2932,5 @@ private void assertValidityTimestamp(PrismObject<UserType> user, long lowerBound
 		AssertJUnit.fail("Expected validityChangeTimestamp to be between "+lowerBound+" and "+upperBound+", but it was "+validityMillis);
 	}
 
-	private <F extends FocusType> void assertEffectiveStatus(PrismObject<F> focus, ActivationStatusType expected) {
-		ActivationType activation = focus.asObjectable().getActivation();
-		assertNotNull("No activation in "+focus, activation);
-		assertEquals("Unexpected effective activation status in "+focus, expected, activation.getEffectiveStatus());
-	}
-
 
 }

model/model-test/src/main/java/com/evolveum/midpoint/model/test/AbstractModelIntegrationTest.java

@@ -539,6 +539,12 @@ protected void assertAdministrativeStatus(PrismObject<? extends ObjectType> obje
 		assert status != null : "No status property is null in "+object;
 		assert status == expected : "status property is "+status+", expected "+expected+" in "+object;
 	}
+
+	protected <F extends FocusType> void assertEffectiveStatus(PrismObject<F> focus, ActivationStatusType expected) {
+		ActivationType activation = focus.asObjectable().getActivation();
+		assertNotNull("No activation in "+focus, activation);
+		assertEquals("Unexpected effective activation status in "+focus, expected, activation.getEffectiveStatus());
+	}
 
 	protected void modifyUserReplace(String userOid, QName propertyName, Task task, OperationResult result, Object... newRealValue)
 			throws ObjectNotFoundException, SchemaException, ExpressionEvaluationException, CommunicationException,

testing/story/src/test/java/com/evolveum/midpoint/testing/story/AbstractStoryTest.java

@@ -1,6 +1,5 @@
-package com.evolveum.midpoint.testing.story;
 /*
- * Copyright (c) 2013 Evolveum
+ * Copyright (c) 2013-2018 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -14,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+package com.evolveum.midpoint.testing.story;
 
 import com.evolveum.midpoint.model.test.AbstractModelIntegrationTest;
 import com.evolveum.midpoint.prism.PrismObject;
@@ -104,7 +104,7 @@ public void initSystem(Task initTask, OperationResult initResult) throws Excepti
 
 		// User administrator
 		userAdministrator = repoAddObjectFromFile(USER_ADMINISTRATOR_FILE, initResult);
-		repoAddObjectFromFile(USER_JACK_FILE, true, initResult).asObjectable();
+		repoAddObjectFromFile(USER_JACK_FILE, true, initResult);
 		repoAddObjectFromFile(ROLE_SUPERUSER_FILE, initResult);
 		login(userAdministrator);
 

testing/story/src/test/java/com/evolveum/midpoint/testing/story/TestExistentialIssues.java

@@ -0,0 +1,264 @@
+/*
+ * Copyright (c) 2018 Evolveum
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.evolveum.midpoint.testing.story;
+
+import java.io.File;
+
+import org.springframework.test.annotation.DirtiesContext;
+import org.springframework.test.annotation.DirtiesContext.ClassMode;
+import org.springframework.test.context.ContextConfiguration;
+import org.testng.annotations.Test;
+
+import com.evolveum.midpoint.prism.PrismObject;
+import com.evolveum.midpoint.schema.result.OperationResult;
+import com.evolveum.midpoint.task.api.Task;
+import com.evolveum.midpoint.test.util.MidPointTestConstants;
+import com.evolveum.midpoint.xml.ns._public.common.common_3.ActivationStatusType;
+import com.evolveum.midpoint.xml.ns._public.common.common_3.UserType;
+
+/**
+ * Tests for weird activation existence mappings, delayed deletes and similar existential issues.
+ * 
+ * MID-4564
+ * 
+ * @author Radovan Semancik
+ */
+@ContextConfiguration(locations = { "classpath:ctx-story-test-main.xml" })
+@DirtiesContext(classMode = ClassMode.AFTER_CLASS)
+public class TestExistentialIssues extends AbstractStoryTest {
+
+	public static final File TEST_DIR = new File(MidPointTestConstants.TEST_RESOURCES_DIR, "existential");
+
+	protected static final File RESOURCE_DUMMY_LAZY_FILE = new File(TEST_DIR, "resource-dummy-lazy.xml");
+	protected static final String RESOURCE_DUMMY_LAZY_OID = "306555be-3e38-11e8-bd96-7b572e4e7d89";
+	protected static final String RESOURCE_DUMMY_LAZY_NAME = "lazy";
+
+	protected static final File USER_DESCARTES_FILE = new File(TEST_DIR, "user-descartes.xml");
+	protected static final String USER_DESCARTES_OID = "d642c1bc-3e36-11e8-8346-bf95880c9be7";
+	protected static final String USER_DESCARTES_USERNAME = "descartes";
+	protected static final String USER_DESCARTES_FULL_NAME = "René Descartes";
+
+	protected PrismObject<UserType> userAdministrator;
+
+	@Override
+	public void initSystem(Task initTask, OperationResult initResult) throws Exception {
+		super.initSystem(initTask, initResult);
+
+		initDummyResourcePirate(RESOURCE_DUMMY_LAZY_NAME,
+				RESOURCE_DUMMY_LAZY_FILE, RESOURCE_DUMMY_LAZY_OID, initTask, initResult);
+
+		repoAddObjectFromFile(USER_DESCARTES_FILE, true, initResult);
+	}
+
+	/**
+	 * Mostly just sanity check and preparation.
+	 */
+	@Test
+	public void test100DisableUserDescartes() throws Exception {
+		final String TEST_NAME = "test100DisableUserDescartes";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		modifyUserReplace(USER_DESCARTES_OID, ACTIVATION_ADMINISTRATIVE_STATUS_PATH, task, result, ActivationStatusType.DISABLED);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		PrismObject<UserType> userAfter = getUserFromRepo(USER_DESCARTES_OID);
+		display("User after (repo)", userAfter);
+		assertAdministrativeStatusDisabled(userAfter);
+		assertEffectiveStatus(userAfter, ActivationStatusType.DISABLED);
+		assertAssignments(userAfter, 0);
+		assertLinks(userAfter, 0);
+
+		assertNoDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME);
+	}
+
+	/**
+	 * MID-4564
+	 */
+	@Test
+	public void test110DescartesAssignLazyAccount() throws Exception {
+		final String TEST_NAME = "test110DescartesAssignLazyAccount";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		assignAccount(USER_DESCARTES_OID, RESOURCE_DUMMY_LAZY_OID, null, task, result);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		PrismObject<UserType> userAfter = getUserFromRepo(USER_DESCARTES_OID);
+		display("User after (repo)", userAfter);
+		assertAdministrativeStatusDisabled(userAfter);
+		assertEffectiveStatus(userAfter, ActivationStatusType.DISABLED);
+		assertAssignments(userAfter, 1);
+		assertLinks(userAfter, 0);
+
+		assertNoDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME);
+	}
+
+	/**
+	 * MID-4564
+	 */
+	@Test
+	public void test112EnableDescartes() throws Exception {
+		final String TEST_NAME = "test112EnableDescartes";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		modifyUserReplace(USER_DESCARTES_OID, ACTIVATION_ADMINISTRATIVE_STATUS_PATH, task, result, ActivationStatusType.ENABLED);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		PrismObject<UserType> userAfter = getUserFromRepo(USER_DESCARTES_OID);
+		display("User after (repo)", userAfter);
+		assertAdministrativeStatusEnabled(userAfter);
+		assertEffectiveStatus(userAfter, ActivationStatusType.ENABLED);
+		assertAssignments(userAfter, 1);
+		assertLinks(userAfter, 1);
+
+		assertDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME, USER_DESCARTES_FULL_NAME, true);
+	}
+
+	/**
+	 * MID-4564
+	 */
+	@Test
+	public void test114DisableDescartes() throws Exception {
+		final String TEST_NAME = "test112EnableDescartes";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		modifyUserReplace(USER_DESCARTES_OID, ACTIVATION_ADMINISTRATIVE_STATUS_PATH, task, result, ActivationStatusType.DISABLED);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		PrismObject<UserType> userAfter = getUserFromRepo(USER_DESCARTES_OID);
+		display("User after (repo)", userAfter);
+		assertAdministrativeStatusDisabled(userAfter);
+		assertEffectiveStatus(userAfter, ActivationStatusType.DISABLED);
+		assertAssignments(userAfter, 1);
+		assertLinks(userAfter, 1);
+
+		assertDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME, USER_DESCARTES_FULL_NAME, false);
+	}
+
+	/**
+	 * MID-4564
+	 */
+	@Test
+	public void test116ReenableDescartes() throws Exception {
+		final String TEST_NAME = "test116ReenableDescartes";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		modifyUserReplace(USER_DESCARTES_OID, ACTIVATION_ADMINISTRATIVE_STATUS_PATH, task, result, ActivationStatusType.ENABLED);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		PrismObject<UserType> userAfter = getUserFromRepo(USER_DESCARTES_OID);
+		display("User after (repo)", userAfter);
+		assertAdministrativeStatusEnabled(userAfter);
+		assertEffectiveStatus(userAfter, ActivationStatusType.ENABLED);
+		assertAssignments(userAfter, 1);
+		assertLinks(userAfter, 1);
+
+		assertDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME, USER_DESCARTES_FULL_NAME, true);
+	}
+
+	/**
+	 * MID-4564
+	 */
+	@Test
+	public void test120DescartesUnassignLazyAccount() throws Exception {
+		final String TEST_NAME = "test120DescartesUnassignLazyAccount";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		unassignAccount(USER_DESCARTES_OID, RESOURCE_DUMMY_LAZY_OID, null, task, result);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		PrismObject<UserType> userAfter = getUserFromRepo(USER_DESCARTES_OID);
+		display("User after (repo)", userAfter);
+		assertAdministrativeStatusEnabled(userAfter);
+		assertEffectiveStatus(userAfter, ActivationStatusType.ENABLED);
+		assertAssignments(userAfter, 0);
+		assertLinks(userAfter, 1);
+
+		assertDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME, USER_DESCARTES_FULL_NAME, false);
+	}
+
+	/**
+	 * MID-4564
+	 */
+	@Test
+	public void test129DeleteDescartes() throws Exception {
+		final String TEST_NAME = "test129DeleteDescartes";
+		displayTestTitle(TEST_NAME);
+		Task task = createTask(TEST_NAME);
+		OperationResult result = task.getResult();
+
+		// WHEN
+		displayWhen(TEST_NAME);
+
+		deleteObject(UserType.class, USER_DESCARTES_OID, task, result);
+
+		// THEN
+		displayThen(TEST_NAME);
+		assertSuccess(result);
+
+		assertNoObject(UserType.class, USER_DESCARTES_OID);
+
+		assertNoDummyAccount(RESOURCE_DUMMY_LAZY_NAME, USER_DESCARTES_USERNAME);
+	}
+
+}