Issue warning for invalid reset pwd sequence

This resolves MID-8728.
Evolveum · Mar 31, 2023 · 5cadee4 · 5cadee4
1 parent 148149d
commit 5cadee4
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/login/PageLogin.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/login/PageLogin.java
@@ -103,22 +103,24 @@ private void addForgotPasswordLink(SecurityPolicyType securityPolicy) {
     }
 
     private String getPasswordResetUrl(SecurityPolicyType securityPolicy) {
-        String sequenceName = getResetPasswordAuthenticationSequenceName(securityPolicy);
-
-        if (StringUtils.isBlank(sequenceName)) {
+        String resetSequenceIdOrName = getResetPasswordAuthenticationSequenceName(securityPolicy);
+        if (StringUtils.isBlank(resetSequenceIdOrName)) {
             return "";
         }
 
-        AuthenticationSequenceType sequence = SecurityUtils.getSequenceByIdentifier(securityPolicy.getCredentialsReset().getAuthenticationSequenceName(), securityPolicy.getAuthentication());
+        AuthenticationsPolicyType authenticationPolicy = securityPolicy.getAuthentication();
+        AuthenticationSequenceType sequence = SecurityUtils.getSequenceByIdentifier(resetSequenceIdOrName, authenticationPolicy);
         if (sequence == null) {
-            sequence = SecurityUtils.getSequenceByName(securityPolicy.getCredentialsReset().getAuthenticationSequenceName(), securityPolicy.getAuthentication());
+            // this lookup by name will be (probably) eventually removed
+            sequence = SecurityUtils.getSequenceByName(resetSequenceIdOrName, authenticationPolicy);
         }
         if (sequence == null) {
+            LOGGER.warn("Password reset authentication sequence '{}' does not exist", resetSequenceIdOrName);
             return "";
         }
 
         if (sequence.getChannel() == null || StringUtils.isBlank(sequence.getChannel().getUrlSuffix())) {
-            String message = "Sequence with name " + sequenceName + " doesn't contain urlSuffix";
+            String message = "Sequence with name " + resetSequenceIdOrName + " doesn't contain urlSuffix";
             LOGGER.error(message, new IllegalArgumentException(message));
             error(message);
             return "";