Skip to content

Commit

Permalink
removed unnecessary div from tabbed panel component, causes problems …
Browse files Browse the repository at this point in the history
…when doing custom padding/margin/borders
  • Loading branch information
1azyman committed Jan 4, 2023
1 parent 0dfde33 commit 60cfba8
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,22 @@
~ and European Union Public License. See LICENSE file for details.
-->
<wicket:panel xmlns:wicket="http://wicket.apache.org">
<div class="card card-primary card-outline card-outline-tabs">
<div class="card-header p-0 border-bottom-0">
<ul class="nav nav-tabs" wicket:id="tabs-container">
<li class="nav-item" wicket:id="tabs">
<a class="nav-link d-flex gap-2 align-items-center" href="#" wicket:id="link">
<i wicket:id="icon"/>
<span wicket:id="title"/>
<small class="badge" wicket:id="count"/>
</a>
</li>
<wicket:remove><!-- TODO fix the style for rightSideTabItem --></wicket:remove>
<li wicket:id="rightSideTabItem" class="pull-right" style="border-radius: 0; margin: 10px"><div wicket:id="rightSideTab"/></li>
</ul>
</div>
<div class="card-body">
<div class="tab-content">
<div wicket:id="panel" class="tab-pane active" />
</div>
<div class="card-header p-0 border-bottom-0">
<ul class="nav nav-tabs" wicket:id="tabs-container">
<li class="nav-item" wicket:id="tabs">
<a class="nav-link d-flex gap-2 align-items-center" href="#" wicket:id="link">
<i wicket:id="icon"/>
<span wicket:id="title"/>
<small class="badge" wicket:id="count"/>
</a>
</li>
<wicket:remove><!-- TODO fix the style for rightSideTabItem --></wicket:remove>
<li wicket:id="rightSideTabItem" class="pull-right" style="border-radius: 0; margin: 10px"><div wicket:id="rightSideTab"/></li>
</ul>
</div>
<div class="card-body">
<div class="tab-content">
<div wicket:id="panel" class="tab-pane active" />
</div>
</div>
</wicket:panel>
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ public Integer getObject() {
}
};

add(AttributeModifier.prepend("class", "card card-primary card-outline card-outline-tabs"));

WebMarkupContainer tabsContainer = newTabsContainer(ID_TABS_CONTAINER);
tabsContainer.setOutputMarkupId(true);
tabsContainer.setOutputMarkupPlaceholderTag(true);
Expand Down

0 comments on commit 60cfba8

Please sign in to comment.