Audit log CSS fix (MID-4300)

Evolveum · Feb 15, 2018 · 67d86ce · 67d86ce
1 parent cd811b2
commit 67d86ce
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 21 deletions.
diff --git a/...n-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/PageAuditLogDetails.html b/...n-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/PageAuditLogDetails.html
@@ -25,84 +25,84 @@
 				<div class="box box-success">
 					<table class="table table-striped" style="word-break: break-word;">
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.eventTimestamp" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.eventTimestamp" /></td>
 							<td><span wicket:id="timestamp" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message
+							<td class="prop-name"><wicket:message
 									key="PageAuditLogDetails.eventIdentifier" /></td>
 							<td><span wicket:id="eventIdentifier" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.eventType" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.eventType" /></td>
 							<td><span wicket:id="eventType" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.eventStage" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.eventStage" /></td>
 							<td><span wicket:id="eventStage" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message
+							<td class="prop-name"><wicket:message
 									key="PageAuditLogDetails.eventInitiatorRef" /></td>
 							<td><span wicket:id="initiatorRef" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message
+							<td class="prop-name"><wicket:message
 									key="PageAuditLogDetails.eventAttorneyRef" /></td>
 							<td><span wicket:id="attorneyRef" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.eventTargetRef" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.eventTargetRef" /></td>
 							<td><span wicket:id="targetRef" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message
+							<td class="prop-name"><wicket:message
 									key="PageAuditLogDetails.eventTargetOwnerRef" /></td>
 							<td><span wicket:id="targetOwnerRef" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.eventResult" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.eventResult" /></td>
 							<td><span wicket:id="result" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.eventOutcome" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.eventOutcome" /></td>
 							<td><span wicket:id="outcome" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message
+							<td class="prop-name"><wicket:message
 									key="PageAuditLogDetails.sessionIdentifier" /></td>
 							<td><span wicket:id="sessionIdentifier" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.taskIdentifier" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.taskIdentifier" /></td>
 							<td><span wicket:id="taskIdentifier" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.taskOID" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.taskOID" /></td>
 							<td><span wicket:id="taskOID" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.hostIdentifier" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.hostIdentifier" /></td>
 							<td><span wicket:id="hostIdentifier" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.nodeIdentifier" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.nodeIdentifier" /></td>
 							<td><span wicket:id="nodeIdentifier" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.remoteHostAddress" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.remoteHostAddress" /></td>
 							<td><span wicket:id="remoteHostAddress" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.channel" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.channel" /></td>
 							<td><span wicket:id="channel" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.parameter" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.parameter" /></td>
 							<td><span wicket:id="parameter" /></td>
 						</tr>
 						<tr>
-							<td><wicket:message key="PageAuditLogDetails.message" /></td>
+							<td class="prop-name"><wicket:message key="PageAuditLogDetails.message" /></td>
 							<td><span wicket:id="message" /></td>
 						</tr>
 					</table>

diff --git a/...n-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/PageAuditLogDetails.java b/...n-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/PageAuditLogDetails.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright (c) 2010-2018 Evolveum
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.evolveum.midpoint.web.page.admin.reports;
 
 import java.util.*;
@@ -54,10 +69,10 @@
                 label = "PageAuditLogViewer.auth.auditLogViewer.label",
                 description = "PageAuditLogViewer.auth.auditLogViewer.description")})
 public class PageAuditLogDetails extends PageBase {
+    private static final long serialVersionUID = 1L;
 
     private static final Trace LOGGER = TraceManager.getTrace(PageAuditLogDetails.class);
 
-    private static final long serialVersionUID = 1L;
     private static final String ID_EVENT_PANEL = "eventPanel";
 
     private static final String ID_DELTA_LIST_PANEL = "deltaListPanel";

diff --git a/...main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.java b/...main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright (c) 2010-2018 Evolveum
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package com.evolveum.midpoint.web.page.admin.reports.component;
 
 import static java.util.stream.Collectors.toList;
@@ -82,6 +97,7 @@
  */
 public class AuditLogViewerPanel extends BasePanel<AuditSearchDto> {
 	private static final long serialVersionUID = 1L;
+
     private static final String ID_PARAMETERS_PANEL = "parametersPanel";
     private static final String ID_TABLE = "table";
     private static final String ID_FROM = "fromField";
@@ -503,8 +519,9 @@ protected List<IColumn<AuditEventRecordType, String>> initColumns() {
             @Override
             protected IModel<String> createLinkModel(final IModel<AuditEventRecordType> rowModel){
                 return new AbstractReadOnlyModel<String>() {
+					private static final long serialVersionUID = 1L;
 
-                    @Override
+					@Override
                     public String getObject() {
                         XMLGregorianCalendar time = rowModel.getObject().getTimestamp();
                         return WebComponentUtil.formatDate(time);

diff --git a/gui/admin-gui/src/main/resources/static/less/midpoint-theme.less b/gui/admin-gui/src/main/resources/static/less/midpoint-theme.less
@@ -1273,4 +1273,13 @@ dd.stacktrace::before {
 	.box-content {
 		padding: 15px;
 	}
+}
+
+// Tables where the first column is the name of the property/attribute
+// (e.g. audit log item details)
+// see MID-4300
+
+td.prop-name {
+	min-width: 90px;
+	font-weight: bold;
 }