Clarify notes on missing features

Evolveum · Dec 16, 2022 · 7c78c7e · 7c78c7e
1 parent 5712158
commit 7c78c7e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/testing/story/src/test/java/com/evolveum/midpoint/testing/story/TestFirstSteps.java b/testing/story/src/test/java/com/evolveum/midpoint/testing/story/TestFirstSteps.java
@@ -95,10 +95,11 @@ public class TestFirstSteps extends AbstractStoryTest {
     private static final CsvResource RESOURCE_HR_160 = createHrResource("resource-hr-160.xml");
     private static final CsvResource RESOURCE_HR_170 = createHrResource("resource-hr-170.xml");
 
+    private static final File INITIAL_LDIF_FILE = new File(TEST_DIR, "initial.ldif");
+
     private static final int PROTECTED_OPENDJ_ACCOUNTS = 4;
     private static final int REGULAR_INITIAL_OPENDJ_ACCOUNTS = 9;
     private static final int ALL_INITIAL_OPENDJ_ACCOUNTS = PROTECTED_OPENDJ_ACCOUNTS + REGULAR_INITIAL_OPENDJ_ACCOUNTS;
-    private static final File INITIAL_LDIF_FILE = new File(TEST_DIR, "initial.ldif");
 
     private static final String RESOURCE_OPENDJ_OID = "0934922f-0f63-4768-b1b1-eab4275b31d1";
 

diff --git a/testing/story/src/test/resources/first-steps/resource-opendj-240.xml b/testing/story/src/test/resources/first-steps/resource-opendj-240.xml
@@ -112,8 +112,12 @@
                             <tier>1</tier>
                         </composition>
                     </items>
-                    <!-- TODO we need some "negative conditions" like telling that emailAddress matching should not apply
-                          if the employeeNumber is present and not matching -->
+                    <!--
+                     We need some "negative conditions" here. In particular, we need to tell midPoint that emailAddress
+                     matching should not apply if the employeeNumber is present and not matching. Because of the tier 1
+                     definition above, the condition could be simply "employeeNumber != null".
+                     See https://docs.evolveum.com/midpoint/methodology/first-steps/solution/#conditions-for-items-correlators.
+                    -->
                     <items>
                         <item>
                             <ref>emailAddress</ref>

diff --git a/testing/story/src/test/resources/first-steps/resource-opendj-290.xml b/testing/story/src/test/resources/first-steps/resource-opendj-290.xml
@@ -50,7 +50,8 @@
                     </target>
                     <!-- This is a kind of hack. We want to correlate on this attribute by a simple mapping but do not want
                          to use it to really modify the focus. This may happen for correlation attributes on non-authoritative
-                         resources (e.g. target ones, or "auxiliary" source ones). Repeated for other attributes. -->
+                         resources (e.g. target ones, or "auxiliary" source ones). Repeated for other attributes.
+                         See https://docs.evolveum.com/midpoint/methodology/first-steps/solution/#correlation-only-mappings. -->
                     <evaluationPhases>
                         <include>beforeCorrelation</include>
                         <exclude>clockwork</exclude>