MID-7484: Transport.init() renamed to configure() and javadoc added

model/model-test/src/main/java/com/evolveum/midpoint/model/test/DummyTransport.java

@@ -99,7 +99,7 @@ public String debugDump(int indent) {
     }
 
     @Override
-    public void init(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
         // not called for legacy transport component
     }
 

model/notifications-api/src/main/java/com/evolveum/midpoint/notifications/api/transports/Transport.java

@@ -22,6 +22,15 @@
  */
 public interface Transport<C extends GeneralTransportConfigurationType> {
 
+    /**
+     * Configures transport instance - this must be fast and exception free.
+     * This is not the place to start any connections or sessions; this is called after sysconfig is changed.
+     *
+     * @param configuration portion of the configuration relevant to this transport
+     * @param transportSupport support object with dependencies
+     */
+    void configure(@NotNull C configuration, @NotNull TransportSupport transportSupport);
+
     /**
      * Sends the message via this transport.
      *
@@ -41,6 +50,4 @@ public interface Transport<C extends GeneralTransportConfigurationType> {
 
     // not-null for new transports, but legacy transports return null (remove after 4.6 cleanup if that happens)
     C getConfiguration();
-
-    void init(@NotNull C configuration, @NotNull TransportSupport transportSupport);
 }

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/CustomMessageTransport.java

@@ -55,7 +55,9 @@ public class CustomMessageTransport implements Transport<CustomTransportConfigur
     private TransportSupport transportSupport;
 
     @Override
-    public void init(@NotNull CustomTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(
+            @NotNull CustomTransportConfigurationType configuration,
+            @NotNull TransportSupport transportSupport) {
         this.configuration = Objects.requireNonNull(configuration);
         name = Objects.requireNonNull(configuration.getName());
         this.transportSupport = Objects.requireNonNull(transportSupport);

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/FileMessageTransport.java

@@ -8,6 +8,8 @@
 
 import static com.evolveum.midpoint.transport.impl.TransportUtil.formatToFileNew;
 
+import java.util.Objects;
+
 import org.jetbrains.annotations.NotNull;
 
 import com.evolveum.midpoint.notifications.api.events.Event;
@@ -36,9 +38,11 @@ public class FileMessageTransport implements Transport<FileTransportConfiguratio
     private FileTransportConfigurationType configuration;
 
     @Override
-    public void init(@NotNull FileTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
-        this.configuration = java.util.Objects.requireNonNull(configuration);
-        name = java.util.Objects.requireNonNull(configuration.getName());
+    public void configure(
+            @NotNull FileTransportConfigurationType configuration,
+            @NotNull TransportSupport transportSupport) {
+        this.configuration = Objects.requireNonNull(configuration);
+        name = Objects.requireNonNull(configuration.getName());
         // transportSupport not needed here
     }
 

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/MailMessageTransport.java

@@ -11,10 +11,8 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Paths;
-import java.util.ArrayList;
-import java.util.Date;
-import java.util.List;
-import java.util.Properties;
+import java.util.Objects;
+import java.util.*;
 import javax.activation.DataHandler;
 import javax.activation.DataSource;
 import javax.activation.FileDataSource;
@@ -61,9 +59,11 @@ public class MailMessageTransport implements Transport<MailTransportConfiguratio
     private TransportSupport transportSupport;
 
     @Override
-    public void init(@NotNull MailTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
-        this.configuration = java.util.Objects.requireNonNull(configuration);
-        name = java.util.Objects.requireNonNull(configuration.getName());
+    public void configure(
+            @NotNull MailTransportConfigurationType configuration,
+            @NotNull TransportSupport transportSupport) {
+        this.configuration = Objects.requireNonNull(configuration);
+        name = Objects.requireNonNull(configuration.getName());
         this.transportSupport = transportSupport;
     }
 

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/SmsMessageTransport.java

@@ -18,6 +18,7 @@
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
+import java.util.Objects;
 import java.util.stream.Collectors;
 import javax.xml.namespace.QName;
 
@@ -75,9 +76,11 @@ public class SmsMessageTransport implements Transport<SmsTransportConfigurationT
     private TransportSupport transportSupport;
 
     @Override
-    public void init(@NotNull SmsTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
-        this.configuration = java.util.Objects.requireNonNull(configuration);
-        name = java.util.Objects.requireNonNull(configuration.getName());
+    public void configure(
+            @NotNull SmsTransportConfigurationType configuration,
+            @NotNull TransportSupport transportSupport) {
+        this.configuration = Objects.requireNonNull(configuration);
+        name = Objects.requireNonNull(configuration.getName());
         this.transportSupport = transportSupport;
     }
 

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/TransportServiceImpl.java

@@ -186,7 +186,7 @@ private void createCustomTransport(CustomTransportConfigurationType customConfig
             Transport<CustomTransportConfigurationType> transport = className != null
                     ? (Transport<CustomTransportConfigurationType>) Class.forName(className).getConstructor().newInstance()
                     : new CustomMessageTransport();
-            transport.init(customConfig, transportSupport);
+            transport.configure(customConfig, transportSupport);
             registerTransport(transport);
             transportsFromSysConfig.add(transport.getName());
         } catch (ReflectiveOperationException | ClassCastException e) {
@@ -202,7 +202,7 @@ private <C extends GeneralTransportConfigurationType> void createTransport(
             return;
         }
         Transport<C> transport = transportSupplier.get();
-        transport.init(transportConfig, transportSupport);
+        transport.configure(transportConfig, transportSupport);
         registerTransport(transport);
         transportsFromSysConfig.add(transport.getName());
     }

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/legacy/LegacyCustomTransport.java

@@ -191,7 +191,7 @@ public String getName() {
     }
 
     @Override
-    public void init(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
         // not called for legacy transport component
     }
 

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/legacy/LegacyFileTransport.java

@@ -92,7 +92,7 @@ public String getName() {
     }
 
     @Override
-    public void init(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
         // not called for legacy transport component
     }
 

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/legacy/LegacyMailTransport.java

@@ -335,7 +335,7 @@ public String getName() {
     }
 
     @Override
-    public void init(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
         // not called for legacy transport component
     }
 

model/notifications-impl/src/main/java/com/evolveum/midpoint/transport/impl/legacy/LegacySimpleSmsTransport.java

@@ -402,7 +402,7 @@ public String getName() {
     }
 
     @Override
-    public void init(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(@NotNull GeneralTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
         // not called for legacy transport component
     }
 

model/notifications-impl/src/test/java/com/evolveum/midpoint/notifications/impl/TestMessageTransport.java

@@ -31,7 +31,7 @@
  * This is only useful for the simplest cases without using system configuration.
  * * Specifying its class name for custom transport and calling sysconfig modify.
  * In this case the change will cause transport service to register the transport
- * and its {@link #init} method will be called.
+ * and its {@link #configure} method will be called.
  * The instance then can be obtained by {@link TransportService#getTransport}.
  *
  * Afterwards, use {@link #getMessages()} and {@link #clearMessages()} as needed.
@@ -84,7 +84,7 @@ public String getName() {
     }
 
     @Override
-    public void init(@NotNull CustomTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
+    public void configure(@NotNull CustomTransportConfigurationType configuration, @NotNull TransportSupport transportSupport) {
         this.configuration = configuration;
         name = configuration.getName();
     }