fix for bugs on export popup panel after merge

Evolveum · May 27, 2020 · 814d8ae · 814d8ae
1 parent ab0647b
commit 814d8ae
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/...gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingFilterTabPanel.java b/...gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingFilterTabPanel.java
@@ -11,6 +11,7 @@
 import com.evolveum.midpoint.gui.api.component.result.MessagePanel;
 import com.evolveum.midpoint.gui.api.model.LoadableModel;
 import com.evolveum.midpoint.prism.query.ObjectFilter;
+import com.evolveum.midpoint.prism.query.ObjectQuery;
 import com.evolveum.midpoint.util.exception.SchemaException;
 import com.evolveum.midpoint.util.logging.LoggingUtils;
 import com.evolveum.midpoint.util.logging.Trace;
@@ -128,7 +129,11 @@ public boolean isEnabled() {
 
     public SearchFilterType getFilter() {
         if (check.getObject()) {
-            ObjectFilter filter = search.getObject().createObjectQuery(getPageBase().getPrismContext()).getFilter();
+            ObjectQuery query = search.getObject().createObjectQuery(getPageBase().getPrismContext());
+            if (query == null) {
+                return null;
+            }
+            ObjectFilter filter = query.getFilter();
             SearchFilterType origSearchFilter = null;
             try {
                 origSearchFilter = getPageBase().getPrismContext().getQueryConverter().createSearchFilterType(filter);

diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingPanel.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingPanel.java
@@ -8,6 +8,7 @@
 package com.evolveum.midpoint.web.component.dialog;
 
 import java.util.ArrayList;
+import java.util.Iterator;
 import java.util.List;
 
 import com.evolveum.midpoint.gui.api.component.tabs.PanelTab;
@@ -193,7 +194,12 @@ public WebMarkupContainer createPanel(String panelId) {
         tabs.add(new PanelTab(getPageBase().createStringResource("ExportingPopupPanel.filter")) {
             @Override
             public WebMarkupContainer createPanel(String panelId) {
-                return new ExportingFilterTabPanel(panelId, search, feedbackList);
+                return new ExportingFilterTabPanel(panelId, search, feedbackList){
+                    @Override
+                    public PageBase getPageBase() {
+                        return ExportingPanel.this.getPageBase();
+                    }
+                };
             }
         });
         return tabs;
@@ -238,7 +244,18 @@ public void populateItem(Item<ICellPopulator<SelectableBean<Integer>>> cellItem,
         columns.add(nameColumn);
 
         SelectableListDataProvider<SelectableBean<Integer>, Integer> provider =
-                new SelectableListDataProvider<SelectableBean<Integer>, Integer>(getPageBase(), Model.ofList(exportableColumnIndex));
+                new SelectableListDataProvider<SelectableBean<Integer>, Integer>(getPageBase(), Model.ofList(exportableColumnIndex)){
+
+                    @Override
+                    public Iterator<SelectableBean<Integer>> internalIterator(long first, long count) {
+
+                        if (getAvailableData().isEmpty()) {
+                            return super.internalIterator(first, count);
+                        } else {
+                            return getAvailableData().iterator();
+                        }
+                    }
+                };
 
         BoxedTablePanel<SelectableBean<Integer>> table =
                 new BoxedTablePanel<SelectableBean<Integer>>(id, provider, columns, null, 20) {