identity recovery: rewrite the list of candidates after each correlat…

…ion step; auth exception in case of zero candidates (should be reworked)
Evolveum · Oct 11, 2023 · 829e40e · 829e40e
1 parent 0c68172
commit 829e40e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/...dpoint/authentication/impl/module/authentication/CorrelationModuleAuthenticationImpl.java b/...dpoint/authentication/impl/module/authentication/CorrelationModuleAuthenticationImpl.java
@@ -73,7 +73,8 @@ public boolean isEmptyCorrelatorsList() {
         return CollectionUtils.isEmpty(correlators);
     }
 
-    public void addCandidateOwners(CandidateOwnersMap map) {
+    public void rewriteCandidateOwners(CandidateOwnersMap map) {
+        candidateOwners.clear();
         candidateOwners.mergeWith(map);
     }
 

diff --git a/...src/main/java/com/evolveum/midpoint/authentication/impl/provider/CorrelationProvider.java b/...src/main/java/com/evolveum/midpoint/authentication/impl/provider/CorrelationProvider.java
@@ -73,6 +73,10 @@ public Authentication doAuthenticate(
                     focusType);
             ObjectType owner = correlationResult.getOwner();
 
+            if (owner == null && !candidateOwnerExist(correlationResult)) {
+                throw new AuthenticationServiceException("No identity is found.");
+            }
+
             correlationModuleAuthentication.addAttributes(correlationVerificationToken.getDetails());
 
             correlationModuleAuthentication.setPreFocus(correlationVerificationToken.getPreFocus(focusType,
@@ -93,7 +97,7 @@ public Authentication doAuthenticate(
             }
 
             CandidateOwnersMap ownersMap = correlationResult.getCandidateOwnersMap();
-            correlationModuleAuthentication.addCandidateOwners(ownersMap);
+            correlationModuleAuthentication.rewriteCandidateOwners(ownersMap);
 
             return authentication;
         } catch (Exception e) {