Add SimulationResultManager#getMetricDefinition

model/model-api/src/main/java/com/evolveum/midpoint/model/api/simulation/SimulationResultManager.java

@@ -11,6 +11,8 @@
 
 import com.evolveum.midpoint.model.api.ModelInteractionService;
 
+import com.evolveum.midpoint.xml.ns._public.common.common_3.SimulationMetricDefinitionType;
+
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 import org.jetbrains.annotations.VisibleForTesting;
@@ -80,6 +82,9 @@ <X> X executeInSimulationMode(
             @NotNull SimulatedFunctionCall<X> functionCall)
                     throws CommonException;
 
+    /** Returns the definition of a metric or `null` if there's none. */
+    @Nullable SimulationMetricDefinitionType getMetricDefinition(@NotNull String identifier);
+
     interface SimulatedFunctionCall<X> {
         X execute() throws CommonException;
     }

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/simulation/AggregatedMetricsComputation.java

@@ -73,7 +73,7 @@ static AggregatedMetricsComputation create(@NotNull OperationResult result) {
     }
 
     private void initialize(@NotNull OperationResult result) throws ConfigurationException {
-        List<SimulationMetricDefinitionType> definitions = simulationResultManager.getMetricDefinitions();
+        Collection<SimulationMetricDefinitionType> definitions = simulationResultManager.getMetricDefinitions();
         LOGGER.trace("Processing {} global metric definitions", definitions.size());
         for (SimulationMetricDefinitionType definition : definitions) {
             SimulationMetricComputationType objectValueComputation = definition.getComputation();

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/simulation/ObjectMetricsComputation.java

@@ -30,6 +30,7 @@
 
 import java.math.BigDecimal;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 
 /**
@@ -47,13 +48,13 @@ class ObjectMetricsComputation<O extends ObjectType> {
 
     @NotNull private final ProcessedObject<O> processedObject;
     @NotNull private final LensElementContext<O> elementContext;
-    @NotNull private final List<SimulationMetricDefinitionType> metricDefinitions;
+    @NotNull private final Collection<SimulationMetricDefinitionType> metricDefinitions;
     @NotNull private final Task task;
 
     private ObjectMetricsComputation(
             @NotNull ProcessedObject<O> processedObject,
             @NotNull LensElementContext<O> elementContext,
-            @NotNull List<SimulationMetricDefinitionType> metricDefinitions,
+            @NotNull Collection<SimulationMetricDefinitionType> metricDefinitions,
             @NotNull Task task) {
         this.processedObject = processedObject;
         this.elementContext = elementContext;
@@ -64,7 +65,7 @@ private ObjectMetricsComputation(
     static <O extends ObjectType> List<SimulationProcessedObjectMetricValueType> computeAll(
             ProcessedObject<O> processedObject,
             LensElementContext<O> elementContext,
-            List<SimulationMetricDefinitionType> metricDefinitions,
+            Collection<SimulationMetricDefinitionType> metricDefinitions,
             Task task,
             OperationResult result) throws CommonException {
         return new ObjectMetricsComputation<>(processedObject, elementContext, metricDefinitions, task)

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/simulation/SimulationResultManagerImpl.java

@@ -59,8 +59,8 @@ public class SimulationResultManagerImpl implements SimulationResultManager, Sys
     /** Global definitions provided by the system configuration. */
     @NotNull private volatile List<SimulationDefinitionType> simulationDefinitions = new ArrayList<>();
 
-    /** Global metric definitions provided by the system configuration. */
-    @NotNull private volatile List<SimulationMetricDefinitionType> metricDefinitions = new ArrayList<>();
+    /** Global metric definitions provided by the system configuration. Keyed by identifier. Immutable. */
+    @NotNull private volatile Map<String, SimulationMetricDefinitionType> metricDefinitions = new HashMap<>();
 
     /** Primitive way of checking we do not write to closed results. */
     @VisibleForTesting
@@ -261,7 +261,11 @@ public void update(@Nullable SystemConfigurationType value) {
         var configuration = value != null ? value.getSimulation() : null;
         if (configuration != null) {
             simulationDefinitions = CloneUtil.cloneCollectionMembers(configuration.getSimulation());
-            metricDefinitions = CloneUtil.cloneCollectionMembers(configuration.getMetric());
+            metricDefinitions = configuration.getMetric().stream()
+                    .map(def -> CloneUtil.toImmutable(def))
+                    .collect(Collectors.toMap(
+                            def -> def.getIdentifier(),
+                            def -> def));
         }
     }
 
@@ -331,8 +335,8 @@ public SimulationResultContext newSimulationContext(@NotNull String resultOid) {
         return new SimulationResultContextImpl(this, resultOid);
     }
 
-    @NotNull List<SimulationMetricDefinitionType> getMetricDefinitions() {
-        return metricDefinitions;
+    @NotNull Collection<SimulationMetricDefinitionType> getMetricDefinitions() {
+        return metricDefinitions.values();
     }
 
     @Override
@@ -371,6 +375,11 @@ public <X> X executeInSimulationMode(
         return returnValue;
     }
 
+    @Override
+    public @Nullable SimulationMetricDefinitionType getMetricDefinition(@NotNull String identifier) {
+        return metricDefinitions.get(identifier);
+    }
+
     /**
      * Checks that we do not write into closed {@link SimulationResultType}.
      * Assumes {@link InternalsConfig#consistencyChecks} be `true`, i.e. usually not employed in production.

model/model-intest/src/test/java/com/evolveum/midpoint/model/intest/simulation/AbstractBasicSimulationExecutionTest.java

@@ -58,6 +58,25 @@ public abstract class AbstractBasicSimulationExecutionTest extends AbstractSimul
 
     abstract TaskExecutionMode getExecutionMode();
 
+    /** Checks whether we can obtain a definition for given metric. */
+    @Test
+    public void test010GetMetricDefinition() {
+        when("obtaining a definition for a known metric");
+        var def = simulationResultManager.getMetricDefinition(METRIC_ATTRIBUTE_MODIFICATIONS_ID);
+
+        then("it is OK");
+        assertThat(def).as("definition").isNotNull();
+        assertThat(def.getIdentifier()).as("identifier").isEqualTo(METRIC_ATTRIBUTE_MODIFICATIONS_ID);
+        assertThat(def.getComputation()).as("computation item").isNotNull();
+        assertThat(def.getDomain()).as("domain item").isNotNull();
+
+        when("obtaining a definition for unknown metric");
+        var def2 = simulationResultManager.getMetricDefinition("nonsense");
+
+        then("it's null");
+        assertThat(def2).isNull();
+    }
+
     /**
      * Creating a user without an account.
      */

model/model-intest/src/test/java/com/evolveum/midpoint/model/intest/simulation/AbstractSimulationsTest.java

@@ -85,6 +85,8 @@ public class AbstractSimulationsTest extends AbstractEmptyModelIntegrationTest {
             "6d8ba4fd-95ee-4d98-80c2-3a194b566f89",
             "simple-development-source");
 
+    static final String METRIC_ATTRIBUTE_MODIFICATIONS_ID = "attribute-modifications";
+
     @BeforeMethod
     public void onNativeOnly() {
         skipIfNotNativeRepository();