Stop writing operationExecution data for reports

It harms performance (a lot). Related to MID-7857.
Evolveum · Apr 6, 2022 · 9d85985 · 9d85985
1 parent 06df862
commit 9d85985
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 8 deletions.
diff --git a/.../com/evolveum/midpoint/report/impl/activity/ClassicCollectionReportExportActivityRun.java b/.../com/evolveum/midpoint/report/impl/activity/ClassicCollectionReportExportActivityRun.java
@@ -71,6 +71,7 @@ public final class ClassicCollectionReportExportActivityRun
     @Override
     public @NotNull ActivityReportingCharacteristics createReportingCharacteristics() {
         return super.createReportingCharacteristics()
+                .skipWritingOperationExecutionRecords(true) // because of performance
                 .determineOverallSizeDefault(ActivityOverallItemCountingOptionType.ALWAYS);
     }
 

diff --git a/...a/com/evolveum/midpoint/report/impl/activity/ClassicDashboardReportExportActivityRun.java b/...a/com/evolveum/midpoint/report/impl/activity/ClassicDashboardReportExportActivityRun.java
@@ -71,6 +71,7 @@ public final class ClassicDashboardReportExportActivityRun
     @Override
     public @NotNull ActivityReportingCharacteristics createReportingCharacteristics() {
         return super.createReportingCharacteristics()
+                .skipWritingOperationExecutionRecords(true) // a bit questionable
                 .determineOverallSizeDefault(ActivityOverallItemCountingOptionType.ALWAYS);
     }
 

diff --git a/...ain/java/com/evolveum/midpoint/report/impl/activity/ReportDataAggregationActivityRun.java b/...ain/java/com/evolveum/midpoint/report/impl/activity/ReportDataAggregationActivityRun.java
@@ -10,11 +10,8 @@
 import java.util.List;
 
 import com.evolveum.midpoint.prism.PrismContext;
-import com.evolveum.midpoint.repo.common.activity.run.ActivityRunException;
-import com.evolveum.midpoint.repo.common.activity.run.ActivityRunInstantiationContext;
+import com.evolveum.midpoint.repo.common.activity.run.*;
 import com.evolveum.midpoint.repo.common.activity.run.processing.ItemProcessingRequest;
-import com.evolveum.midpoint.repo.common.activity.run.SearchBasedActivityRun;
-import com.evolveum.midpoint.repo.common.activity.run.SearchSpecification;
 import com.evolveum.midpoint.report.impl.ReportUtils;
 import com.evolveum.midpoint.report.impl.controller.ExportedReportDataRow;
 import com.evolveum.midpoint.report.impl.controller.ExportedReportHeaderRow;
@@ -64,6 +61,12 @@ final class ReportDataAggregationActivityRun
         setInstanceReady();
     }
 
+    @Override
+    public @NotNull ActivityReportingCharacteristics createReportingCharacteristics() {
+        return super.createReportingCharacteristics()
+                .skipWritingOperationExecutionRecords(true); // partial data objects are deleted anyway
+    }
+
     @Override
     public void beforeRun(OperationResult result) throws CommonException, ActivityRunException {
         support.beforeExecution(result);

diff --git a/...c/main/java/com/evolveum/midpoint/report/impl/activity/ReportDataCreationActivityRun.java b/...c/main/java/com/evolveum/midpoint/report/impl/activity/ReportDataCreationActivityRun.java
@@ -15,16 +15,14 @@
 import java.util.Objects;
 import javax.xml.datatype.XMLGregorianCalendar;
 
+import com.evolveum.midpoint.repo.common.activity.run.*;
+
 import org.jetbrains.annotations.NotNull;
 
 import com.evolveum.midpoint.prism.Containerable;
 import com.evolveum.midpoint.prism.PrismContext;
 import com.evolveum.midpoint.prism.PrismPropertyValue;
 import com.evolveum.midpoint.prism.query.*;
-import com.evolveum.midpoint.repo.common.activity.run.ActivityRunException;
-import com.evolveum.midpoint.repo.common.activity.run.ActivityRunInstantiationContext;
-import com.evolveum.midpoint.repo.common.activity.run.SearchBasedActivityRun;
-import com.evolveum.midpoint.repo.common.activity.run.SearchSpecification;
 import com.evolveum.midpoint.repo.common.activity.run.processing.ItemProcessingRequest;
 import com.evolveum.midpoint.report.impl.ReportServiceImpl;
 import com.evolveum.midpoint.report.impl.ReportUtils;
@@ -86,6 +84,12 @@ public final class ReportDataCreationActivityRun
         setInstanceReady();
     }
 
+    @Override
+    public @NotNull ActivityReportingCharacteristics createReportingCharacteristics() {
+        return super.createReportingCharacteristics()
+                .skipWritingOperationExecutionRecords(true); // because of performance
+    }
+
     /**
      * Called at the beginning of execution of this activity (potentially in a worker task).
      * Here is the place to pre-process the report definition.