MID-7581: During delta update of extension / attribute delete reverse…

… cardinality

During delta update (we know final cardinality) delete index of reverse cardinality
of the same attribute in question.

If it is item delete this ensures both indices are deleted.

repo/repo-sqale/src/main/java/com/evolveum/midpoint/repo/sqale/delta/item/ExtensionItemDeltaProcessor.java

@@ -17,6 +17,8 @@
 import com.evolveum.midpoint.prism.path.ItemPath;
 import com.evolveum.midpoint.repo.sqale.ExtensionProcessor;
 import com.evolveum.midpoint.repo.sqale.delta.ItemDeltaProcessor;
+import com.evolveum.midpoint.repo.sqale.qmodel.ext.MExtItem;
+import com.evolveum.midpoint.repo.sqale.qmodel.ext.MExtItemCardinality;
 import com.evolveum.midpoint.repo.sqale.qmodel.ext.MExtItemHolderType;
 import com.evolveum.midpoint.repo.sqale.update.ExtensionUpdateContext;
 import com.evolveum.midpoint.repo.sqale.update.SqaleUpdateContext;
@@ -57,6 +59,11 @@ public void process(ItemDelta<?, ?> modification) throws RepositoryException, Sc
             return; // not-indexed, no action
         }
 
+        // If the extension is single value (and we know it now, we should proceed with deletion of
+        // multivalue variant and vice-versa (this variants may be indroduced during raw import
+        // or changes in multiplicity of extension definition or resource definition
+        context.deleteItem(reverseCardinality(extProcessor, extItemInfo.item));
+
         if (realValues == null || realValues.isEmpty()) {
             context.deleteItem(extItemInfo.getId());
             return;
@@ -65,4 +72,16 @@ public void process(ItemDelta<?, ?> modification) throws RepositoryException, Sc
         // changed value
         context.setChangedItem(extItemInfo.getId(), extProcessor.extItemValue(item, extItemInfo));
     }
+
+    private String reverseCardinality(ExtensionProcessor extProcessor, MExtItem extItem) {
+        var reverseCardinality = MExtItemCardinality.SCALAR.equals(extItem.cardinality) ? MExtItemCardinality.ARRAY : MExtItemCardinality.SCALAR;
+        var reverseKey = new MExtItem.Key();
+        reverseKey.cardinality = reverseCardinality;
+        reverseKey.itemName = extItem.itemName;
+        reverseKey.valueType = extItem.valueType;
+        reverseKey.holderType = extItem.holderType;
+        // FIXME: Use search rather (do not create additional MExtItem)
+        var reverseItem = context.repositoryContext().resolveExtensionItem(reverseKey);
+        return String.valueOf(reverseItem.id);
+    }
 }