Weaken an assertion during shadow classification

This should fix failing TestSemiManual in provisioning-impl.
Evolveum · Feb 9, 2023 · afeae51 · afeae51
1 parent 9a25435
commit afeae51
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/...l/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/ClassificationHelper.java b/...l/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/ClassificationHelper.java
@@ -142,7 +142,14 @@ private void updateShadowClassificationAndTag(
                 .item(ShadowType.F_TAG).old(oldTag).replace(tag)
                 .asItemDeltas();
 
-        assert !itemDeltas.isEmpty();
+        if (itemDeltas.isEmpty()) {
+            // Strange but possible. If the (new) classification is unknown but the current classification in only partially
+            // unknown (e.g. account/unknown), this method is called, but - in fact - it does not update anything.
+            assert !classification.isKnown();
+            LOGGER.trace("Classification stays unchanged in {}", combinedObject);
+            return;
+        }
+
         if (ctx.getTask().areShadowChangesSimulated()) {
             sendSimulationData(combinedObject, itemDeltas, ctx.getTask(), result);
         } else {