Skip to content

Commit

Permalink
Fix ReportUtils.isMetadata method
Browse files Browse the repository at this point in the history
Actually, phantom changes of modifyApproverRef and modifyApprovalComment
are not so bad in themselves. They only should not be shown in the audit
report. So we fixed the code used for displaying deltas in reports.

This resolves MID-6213.
  • Loading branch information
mederly committed Apr 16, 2020
1 parent 52884c8 commit b8cb6a8
Showing 1 changed file with 8 additions and 8 deletions.
Expand Up @@ -561,16 +561,16 @@ private static String printItemDeltaOldValues(ItemPath itemPath, Collection valu
}

private static boolean isMetadata(ItemDeltaType itemDelta) {
List values = itemDelta.getValue();
for (Object v : values) {
if (v instanceof MetadataType) {
return true;
} else if (v instanceof RawType) {
return isMetadata(itemDelta.getPath());
if (isMetadata(itemDelta.getPath())) {
return true;
} else {
for (Object v : itemDelta.getValue()) {
if (v instanceof MetadataType) {
return true;
}
}
return false;
}

return false;
}

private static boolean isMetadata(ItemPathType itemPath) {
Expand Down

0 comments on commit b8cb6a8

Please sign in to comment.