Turn off op. exec. recording for more task types

(Delete not update shadows and Reindex.)
Evolveum · Jan 20, 2021 · b92272e · b92272e
1 parent 339d298
commit b92272e
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 5 deletions.
diff --git a/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd b/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd
@@ -403,8 +403,8 @@
                 <xsd:annotation>
                     <xsd:documentation>
                         <p>
-                            Description of recent operations executed on this object (or related objects, e.g. shadows
-                            in case of a focal object). The number of operations to be kept here is configurable.
+                            Description of recent operations executed on this object (or related objects in special
+                            cases). The number of operations to be kept here is configurable.
                         </p>
                     </xsd:documentation>
                     <xsd:appinfo>

diff --git a/...main/java/com/evolveum/midpoint/model/impl/integrity/ObjectIntegrityCheckTaskHandler.java b/...main/java/com/evolveum/midpoint/model/impl/integrity/ObjectIntegrityCheckTaskHandler.java
@@ -56,7 +56,7 @@ public ObjectIntegrityCheckTaskHandler() {
         super("Object integrity check", OperationConstants.CHECK_OBJECT_INTEGRITY);
         reportingOptions.setPreserveStatistics(false);
         reportingOptions.setLogErrors(false); // we do log errors ourselves
-        reportingOptions.setSkipWritingOperationExecutionRecords(true);
+        reportingOptions.setSkipWritingOperationExecutionRecords(true); // because of performance
     }
 
     @PostConstruct

diff --git a/...main/java/com/evolveum/midpoint/model/impl/integrity/ShadowIntegrityCheckTaskHandler.java b/...main/java/com/evolveum/midpoint/model/impl/integrity/ShadowIntegrityCheckTaskHandler.java
@@ -58,7 +58,7 @@ public ShadowIntegrityCheckTaskHandler() {
         super("Shadow integrity check", OperationConstants.CHECK_SHADOW_INTEGRITY);
         reportingOptions.setPreserveStatistics(false);
         reportingOptions.setLogErrors(false); // we do log errors ourselves
-        reportingOptions.setSkipWritingOperationExecutionRecords(true);
+        reportingOptions.setSkipWritingOperationExecutionRecords(true); // because of performance
     }
 
     @PostConstruct

diff --git a/...c/main/java/com/evolveum/midpoint/model/impl/tasks/DeleteNotUpdatedShadowTaskHandler.java b/...c/main/java/com/evolveum/midpoint/model/impl/tasks/DeleteNotUpdatedShadowTaskHandler.java
@@ -63,6 +63,7 @@ public class DeleteNotUpdatedShadowTaskHandler
     public DeleteNotUpdatedShadowTaskHandler() {
         super("DeleteNotUpdatedShadow", OperationConstants.DELETE_NOT_UPDATED_SHADOWS);
         reportingOptions.setPreserveStatistics(false);
+        reportingOptions.setSkipWritingOperationExecutionRecords(true); // because the shadows are deleted anyway
     }
 
     @PostConstruct

diff --git a/...l/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ReindexTaskHandler.java b/...l/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ReindexTaskHandler.java
@@ -47,6 +47,7 @@ public class ReindexTaskHandler
     public ReindexTaskHandler() {
         super("Reindex", OperationConstants.REINDEX);
         reportingOptions.setPreserveStatistics(false);
+        reportingOptions.setSkipWritingOperationExecutionRecords(false); // because of performance
     }
 
     @PostConstruct

diff --git a/...c/main/java/com/evolveum/midpoint/provisioning/impl/task/MultiPropagationTaskHandler.java b/...c/main/java/com/evolveum/midpoint/provisioning/impl/task/MultiPropagationTaskHandler.java
@@ -58,7 +58,7 @@ public MultiPropagationTaskHandler() {
         super("Provisioning propagation (multi)", OperationConstants.PROVISIONING_PROPAGATION);
         reportingOptions.setPreserveStatistics(false);
         reportingOptions.setEnableSynchronizationStatistics(false);
-        reportingOptions.setSkipWritingOperationExecutionRecords(true);
+        reportingOptions.setSkipWritingOperationExecutionRecords(true); // to avoid resource change (invalidates the caches)
     }
 
     @PostConstruct