Fix preview changes (MID-5140, MID-5205)

As the deltas are now immutable we simply clone them before using them to compute changes for preview. (We should have done so anyway.)
Evolveum · Mar 21, 2019 · bc2cdc4 · bc2cdc4
1 parent 3e9b9cb
commit bc2cdc4
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/.../src/main/java/com/evolveum/midpoint/web/component/prism/show/PreviewChangesTabPanel.java b/.../src/main/java/com/evolveum/midpoint/web/component/prism/show/PreviewChangesTabPanel.java
@@ -6,6 +6,7 @@
 import com.evolveum.midpoint.model.api.context.ModelProjectionContext;
 import com.evolveum.midpoint.model.api.visualizer.Scene;
 import com.evolveum.midpoint.prism.delta.ObjectDelta;
+import com.evolveum.midpoint.prism.util.CloneUtil;
 import com.evolveum.midpoint.repo.common.ObjectResolver;
 import com.evolveum.midpoint.schema.result.OperationResult;
 import com.evolveum.midpoint.task.api.Task;
@@ -76,12 +77,12 @@ private void initModels(){
         try {
             if (modelContext != null) {
                 if (modelContext.getFocusContext() != null) {
-                    addIgnoreNull(primaryDeltas, modelContext.getFocusContext().getPrimaryDelta());
-                    addIgnoreNull(secondaryDeltas, modelContext.getFocusContext().getSecondaryDelta());
+                    addIgnoreNull(primaryDeltas, CloneUtil.clone(modelContext.getFocusContext().getPrimaryDelta()));
+                    addIgnoreNull(secondaryDeltas, CloneUtil.clone(modelContext.getFocusContext().getSecondaryDelta()));
                 }
                 for (ModelProjectionContext projCtx : modelContext.getProjectionContexts()) {
-                    addIgnoreNull(primaryDeltas, projCtx.getPrimaryDelta());
-                    addIgnoreNull(secondaryDeltas, projCtx.getExecutableDelta());
+                    addIgnoreNull(primaryDeltas, CloneUtil.clone(projCtx.getPrimaryDelta()));
+                    addIgnoreNull(secondaryDeltas, CloneUtil.clone(projCtx.getExecutableDelta()));
                 }
             }
             if (LOGGER.isTraceEnabled()) {