Skip to content

Commit

Permalink
Continuing filters cleanup.
Browse files Browse the repository at this point in the history
  • Loading branch information
mederly committed Oct 12, 2016
1 parent 24d0516 commit c683bf0
Showing 1 changed file with 8 additions and 8 deletions.
Expand Up @@ -533,18 +533,18 @@ private static ObjectFilter evaluateFilterExpressionsInternal(ObjectFilter filte
}
return evaluatedFilter;

} else if (filter instanceof PropertyValueFilter) {
PropertyValueFilter pvfilter = (PropertyValueFilter) filter;
} else if (filter instanceof ValueFilter) {
ValueFilter valueFilter = (ValueFilter) filter;

if (pvfilter.getValues() != null && !pvfilter.getValues().isEmpty()) {
if (valueFilter.getValues() != null && !valueFilter.getValues().isEmpty()) {
// We have value. Nothing to evaluate.
return pvfilter.clone();
return valueFilter.clone();
}

ExpressionWrapper expressionWrapper = pvfilter.getExpression();
ExpressionWrapper expressionWrapper = valueFilter.getExpression();
if (expressionWrapper == null || expressionWrapper.getExpression() == null) {
LOGGER.warn("No valueExpression in filter in {}. Returning original filter", shortDesc);
return pvfilter.clone();
return valueFilter.clone();
}
if (!(expressionWrapper.getExpression() instanceof ExpressionType)) {
throw new SchemaException("Unexpected expression type "
Expand All @@ -561,13 +561,13 @@ private static ObjectFilter evaluateFilterExpressionsInternal(ObjectFilter filte
LOGGER.debug("Result of search filter expression was null or empty. Expression: {}",
valueExpression);

return createFilterForNoValue(pvfilter, valueExpression);
return createFilterForNoValue(valueFilter, valueExpression);
}
// TODO: log more context
LOGGER.trace("Search filter expression in the rule for {} evaluated to {}.",
new Object[] { shortDesc, expressionResult });

ValueFilter evaluatedFilter = pvfilter.clone();
ValueFilter evaluatedFilter = valueFilter.clone();
evaluatedFilter.setValue(expressionResult);
evaluatedFilter.setExpression(null);
// }
Expand Down

0 comments on commit c683bf0

Please sign in to comment.