MID-8842 ninja - NPE fix

(cherry picked from commit 37f9820)
Evolveum · Sep 19, 2023 · d5b9e95 · d5b9e95
1 parent 7a9506b
commit d5b9e95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/...ain/java/com/evolveum/midpoint/ninja/action/upgrade/action/UpgradeInstallationAction.java b/...ain/java/com/evolveum/midpoint/ninja/action/upgrade/action/UpgradeInstallationAction.java
@@ -28,6 +28,9 @@ public String getOperationName() {
     @Override
     public Void execute() throws Exception {
         final File distributionDirectory = options.getDistributionDirectory();
+        if (distributionDirectory == null) {
+            throw new NinjaException("Undefined distribution directory");
+        }
 
         final boolean backupFiles = options.isBackup();
 

diff --git a/...in/java/com/evolveum/midpoint/ninja/action/upgrade/action/UpgradeInstallationOptions.java b/...in/java/com/evolveum/midpoint/ninja/action/upgrade/action/UpgradeInstallationOptions.java
@@ -14,7 +14,7 @@ public class UpgradeInstallationOptions {
 
     public static final String P_INSTALLATION_DIRECTORY = "--installation-directory";
 
-    @Parameter(names = { P_DISTRIBUTION_DIRECTORY }, descriptionKey = "upgradeInstallation.distributionDirectory")
+    @Parameter(names = { P_DISTRIBUTION_DIRECTORY }, descriptionKey = "upgradeInstallation.distributionDirectory", required = true)
     private File distributionDirectory;
 
     @Parameter(names = { P_BACKUP_INSTALLATION_DIRECTORY }, descriptionKey = "upgradeInstallation.backupInstallationDirectory")