common-core-3: few TODOs around script/returnType and objectVariableMode

Evolveum · Mar 3, 2023 · e2376e6 · e2376e6
1 parent deb1cda
commit e2376e6
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd b/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd
@@ -6244,6 +6244,11 @@
                             </xsd:documentation>
                         </xsd:annotation>
                     </xsd:element>
+                    <!--
+                    TODO: Consider renaming, because returnTypeof type QName is used also in expression, which is a mere level above and can be confusing.
+                     Also - this seems to do nothing at the moment, it probably ends in ScriptExpressionEvaluationContext#suggestedReturnType and is not used further.
+                     Related Jira: MID-8552
+                    -->
                     <xsd:element name="returnType" type="tns:ScriptExpressionReturnTypeType" minOccurs="0">
                         <xsd:annotation>
                             <xsd:documentation>
@@ -6253,10 +6258,12 @@
                             </xsd:documentation>
                         </xsd:annotation>
                     </xsd:element>
+                    <!-- TODO: Consider renaming to referenceVariableMode. -->
                     <xsd:element name="objectVariableMode" type="tns:ObjectVariableModeType" minOccurs="0" default="object">
                         <xsd:annotation>
                             <xsd:documentation>
-                                Type of object variables that appear in the script.
+                                Specifies how reference variables should be provided for the script.
+                                By default, they are resolved to objects.
                             </xsd:documentation>
                             <xsd:appinfo>
                                 <a:since>4.0</a:since>
@@ -6343,7 +6350,8 @@
     <xsd:simpleType name="ObjectVariableModeType">
         <xsd:annotation>
             <xsd:documentation>
-                Type of object variables that appear in the script.
+                Specifies how reference variables should be provided for the script.
+                By default, they are resolved to objects.
             </xsd:documentation>
             <xsd:appinfo>
                 <jaxb:typesafeEnumClass/>