added definition name validation

Evolveum · Dec 17, 2015 · e7d634b · e7d634b
1 parent e4f5a44
commit e7d634b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.../src/main/java/com/evolveum/midpoint/web/page/admin/certification/PageCertDefinition.java b/.../src/main/java/com/evolveum/midpoint/web/page/admin/certification/PageCertDefinition.java
@@ -322,7 +322,13 @@ public void savePerformed(AjaxRequestTarget target) {
 //			return;
 //		}
 
-		Task task = createSimpleTask(OPERATION_SAVE_DEFINITION);
+        if (StringUtils.isEmpty(dto.getName())) {
+            error(getString("CertDefinitionPage.message.cantSaveEmptyName"));
+            target.add(getFeedbackPanel());
+            return;
+        }
+
+        Task task = createSimpleTask(OPERATION_SAVE_DEFINITION);
 		OperationResult result = task.getResult();
 		try {
 			AccessCertificationDefinitionType oldObject = dto.getOldDefinition();

diff --git a/gui/admin-gui/src/main/resources/localization/Midpoint.properties b/gui/admin-gui/src/main/resources/localization/Midpoint.properties
@@ -211,6 +211,7 @@ capabilityValuePanel.label.capability.testConnection=Test Connection Capability
 capabilityValuePanel.label.capability.update=Update Capability
 capabilityValuePanel.label.enabled=Enabled
 CertDefinitionPage.message.cantSaveEmpty=Can't save empty XML
+CertDefinitionPage.message.cantSaveEmptyName=Can't save definition with empty name
 ChangeType.ADD=Add
 ChangeType.DELETE=Delete
 ChangeType.MODIFY=Modify