Make attribute definition lookup faster

Instead of using the default (iterative) implementation, we provide
a map that can be used for common cases - immutable definition,
case-insensitive searches.

Preliminary. Does not include e.g. composite definitions (when aux OCs
are used).

infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/AbstractResourceObjectDefinitionImpl.java

@@ -30,6 +30,8 @@
 import com.evolveum.midpoint.prism.annotation.ItemDiagramSpecification;
 import com.evolveum.midpoint.util.QNameUtil;
 
+import static com.evolveum.midpoint.util.MiscUtil.stateCheck;
+
 /**
  * Common implementation for both {@link ResourceObjectClassDefinition} and {@link ResourceObjectTypeDefinition}.
  *
@@ -67,6 +69,14 @@ public abstract class AbstractResourceObjectDefinitionImpl
     @NotNull final DeeplyFreezableList<ResourceAttributeDefinition<?>> attributeDefinitions =
             new DeeplyFreezableList<>();
 
+    /**
+     * Indexed attribute definitions for faster access.
+     * Created (as immutable map) on freezing.
+     *
+     * Temporary/experimental.
+     */
+    private Map<QName, ResourceAttributeDefinition<?>> attributeDefinitionMap;
+
     /**
      * Names of primary identifiers. They are the same for both raw and refined definitions.
      * (Currently we do not support tweaking of this information.)
@@ -169,6 +179,15 @@ public List<? extends ResourceAttributeDefinition<?>> getAttributeDefinitions()
         return associationDefinitions;
     }
 
+    @Override
+    public @Nullable ResourceAttributeDefinition<?> findAttributeDefinition(QName name, boolean caseInsensitive) {
+        if (caseInsensitive || isMutable()) {
+            return ResourceObjectDefinition.super.findAttributeDefinition(name, caseInsensitive);
+        } else {
+            return attributeDefinitionMap.get(name);
+        }
+    }
+
     @NotNull
     @Override
     public Collection<ResourceAttributeDefinition<?>> getPrimaryIdentifiers() {
@@ -439,12 +458,22 @@ public boolean canRepresent(QName typeName) {
     @Override
     protected void performFreeze() {
         attributeDefinitions.freeze();
+        createAttributeDefinitionMap();
         associationDefinitions.freeze();
         primaryIdentifiersNames.freeze();
         secondaryIdentifiersNames.freeze();
         auxiliaryObjectClassDefinitions.freeze();
     }
 
+    private void createAttributeDefinitionMap() {
+        var map = new HashMap<QName, ResourceAttributeDefinition<?>>();
+        attributeDefinitions.forEach(def -> {
+            var previous = map.put(def.getItemName(), def);
+            stateCheck(previous == null, "Multiple definitions for attribute %s in %s", def, this);
+        });
+        attributeDefinitionMap = Collections.unmodifiableMap(map);
+    }
+
     @Override
     public void accept(Visitor<Definition> visitor) {
         visitor.visit(this);

infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceAttributeContainerDefinitionImpl.java

@@ -167,6 +167,13 @@ protected void copyDefinitionDataFrom(ResourceAttributeContainerDefinition sourc
 
     @Override
     public <T> ResourceAttributeDefinition<T> findAttributeDefinition(QName elementQName, boolean caseInsensitive) {
+        var ctd = complexTypeDefinition;
+        if (ctd instanceof ResourceObjectDefinition) {
+            // Shortcut to more efficient lookup implementation - FIXME this is a hack
+            //noinspection unchecked
+            return (ResourceAttributeDefinition<T>)
+                    ((ResourceObjectDefinition) ctd).findAttributeDefinition(elementQName, caseInsensitive);
+        }
         //noinspection unchecked
         return findLocalItemDefinition(ItemName.fromQName(elementQName), ResourceAttributeDefinition.class, caseInsensitive);
     }

infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceObjectTypeDefinitionImpl.java

@@ -205,12 +205,6 @@ public ResourceObjectTypeDefinition deepClone(@NotNull DeepCloneOperation operat
     }
     //endregion
 
-    //region ==== Parsing =================================================================================
-    void add(ResourceAttributeDefinition<?> refinedAttributeDefinition) {
-        attributeDefinitions.add(refinedAttributeDefinition);
-    }
-    //endregion
-
     //region Diagnostic output, hashCode/equals =========================================================
 
     @Override

provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/ProvisioningContext.java

@@ -259,6 +259,9 @@ public Collection<ResourceObjectPattern> getProtectedAccountPatterns(
     public @NotNull ResourceObjectDefinition computeCompositeObjectDefinition(
             @NotNull Collection<QName> auxObjectClassQNames)
             throws SchemaException, ConfigurationException {
+        if (auxObjectClassQNames.isEmpty()) {
+            return getObjectDefinitionRequired();
+        }
         Collection<ResourceObjectDefinition> auxiliaryObjectClassDefinitions = new ArrayList<>(auxObjectClassQNames.size());
         for (QName auxObjectClassQName : auxObjectClassQNames) {
             ResourceObjectDefinition auxObjectClassDef = getResourceSchema().findObjectClassDefinition(auxObjectClassQName);
@@ -267,6 +270,7 @@ public Collection<ResourceObjectPattern> getProtectedAccountPatterns(
             }
             auxiliaryObjectClassDefinitions.add(auxObjectClassDef);
         }
+        // FIXME the attribute lookup in this definition will be slow (iterating through all the definitions)
         return new CompositeObjectDefinitionImpl(
                 getObjectDefinitionRequired(),
                 auxiliaryObjectClassDefinitions);