Support for explosive volatility (MID-3727)

icf-connectors/dummy-connector/src/main/java/com/evolveum/icf/dummy/connector/DummyConfiguration.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2016 Evolveum
+ * Copyright (c) 2010-2017 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -58,6 +58,7 @@ public class DummyConfiguration extends AbstractConfiguration {
 	private boolean addConnectorStateAttributes = false;
 	private boolean supportReturnDefaultAttributes = false;				// used e.g. for livesync vs. auxiliary object classes test
 	private boolean requireNameHint = false;
+	private boolean monsterized = false;
 
 	/**
      * Defines name of the dummy resource instance. There may be several dummy resource running in
@@ -352,6 +353,15 @@ public boolean isRequireNameHint() {
 	public void setRequireNameHint(boolean requireNameHint) {
 		this.requireNameHint = requireNameHint;
 	}
+
+	@ConfigurationProperty
+	public boolean isMonsterized() {
+		return monsterized;
+	}
+
+	public void setMonsterized(boolean monsterized) {
+		this.monsterized = monsterized;
+	}
 
 	/**
      * {@inheritDoc}

icf-connectors/dummy-connector/src/main/java/com/evolveum/icf/dummy/connector/DummyConnector.java

@@ -157,13 +157,9 @@ public void init(Configuration configuration) {
         if (uselessGuardedString == null) {
         	resource.setUselessGuardedString(null);
         } else {
-        	uselessGuardedString.access(new GuardedString.Accessor() {
-    			@Override
-    			public void access(char[] chars) {
-    				resource.setUselessGuardedString(new String(chars));
-    			}
-        	});
+        	uselessGuardedString.access(chars -> resource.setUselessGuardedString(new String(chars)));
         }
+        resource.setMonsterization(this.configuration.isMonsterized());
 
         resource.connect();
 

icf-connectors/dummy-resource/src/main/java/com/evolveum/icf/dummy/resource/DummyObject.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2016 Evolveum
+ * Copyright (c) 2010-2017 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -228,6 +228,15 @@ private void addAttributeValue(String attrName, Set<Object> currentValues, Objec
 			}
 		}
 
+		if (resource != null && resource.isMonsterization() && DummyResource.VALUE_MONSTER.equals(valueToAdd)) {
+			Iterator<Object> iterator = currentValues.iterator();
+			while (iterator.hasNext()) {
+				if (DummyResource.VALUE_COOKIE.equals(iterator.next())) {
+					iterator.remove();
+				}
+			}
+		}
+
 		Set<Object> valuesToCheck = new HashSet<Object>();
 		valuesToCheck.addAll(currentValues);
 		valuesToCheck.add(valueToAdd);

icf-connectors/dummy-resource/src/main/java/com/evolveum/icf/dummy/resource/DummyResource.java

@@ -100,6 +100,20 @@ public class DummyResource implements DebugDumpable {
 	private int groupMembersReadCount = 0;
 	private Collection<String> forbiddenNames;
 
+	/**
+	 * There is a monster that loves to eat cookies.
+	 * If value "monster" is added to an attribute that
+	 * contain the "cookie" value, the monster will
+	 * eat that cookie. Then is goes to sleep. If more
+	 * cookies are added then the monster will not
+	 * eat them.
+	 * MID-3727
+	 */
+	private boolean monsterization = false;
+
+	public static final String VALUE_MONSTER = "monster";
+	public static final String VALUE_COOKIE = "cookie";
+
 	private BreakMode schemaBreakMode = BreakMode.NONE;
 	private BreakMode getBreakMode = BreakMode.NONE;
 	private BreakMode addBreakMode = BreakMode.NONE;
@@ -333,6 +347,14 @@ public void setForbiddenNames(Collection<String> forbiddenNames) {
 		this.forbiddenNames = forbiddenNames;
 	}
 
+	public boolean isMonsterization() {
+		return monsterization;
+	}
+
+	public void setMonsterization(boolean monsterization) {
+		this.monsterization = monsterization;
+	}
+
 	public int getConnectionCount() {
 		return connectionCount;
 	}

infra/common/src/main/java/com/evolveum/midpoint/common/refinery/CompositeRefinedObjectClassDefinitionImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2016 Evolveum
+ * Copyright (c) 2010-2017 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -275,6 +275,11 @@ public ObjectClassComplexTypeDefinition getObjectClassDefinition() {
 	public ResourceObjectReferenceType getBaseContext() {
 		return structuralObjectClassDefinition.getBaseContext();
 	}
+
+	@Override
+	public ResourceObjectVolatilityType getVolatility() {
+		return structuralObjectClassDefinition.getVolatility();
+	}
 
 	@Override
 	public List<MappingType> getPasswordInbound() {

infra/common/src/main/java/com/evolveum/midpoint/common/refinery/LayerRefinedObjectClassDefinitionImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2016 Evolveum
+ * Copyright (c) 2010-2017 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -584,6 +584,11 @@ public ResourceObjectReferenceType getBaseContext() {
 		return refinedObjectClassDefinition.getBaseContext();
 	}
 
+	@Override
+	public ResourceObjectVolatilityType getVolatility() {
+		return refinedObjectClassDefinition.getVolatility();
+	}
+
 	@Override
 	public Class getTypeClassIfKnown() {
 		return refinedObjectClassDefinition.getTypeClassIfKnown();

infra/common/src/main/java/com/evolveum/midpoint/common/refinery/RefinedObjectClassDefinition.java

@@ -129,6 +129,8 @@ default Collection<RefinedAssociationDefinition> getEntitlementAssociationDefini
 	ResourceObjectReferenceType getBaseContext();
 
 	String getHumanReadableName();
+
+	ResourceObjectVolatilityType getVolatility();
 	//endregion
 
 

infra/common/src/main/java/com/evolveum/midpoint/common/refinery/RefinedObjectClassDefinitionImpl.java

@@ -312,6 +312,14 @@ public ShadowKindType getKind() {
 	public void setKind(ShadowKindType kind) {
 		this.kind = kind;
 	}
+
+	@Override
+	public ResourceObjectVolatilityType getVolatility() {
+		if (schemaHandlingObjectTypeDefinitionType == null) {
+			return null;
+		}
+		return schemaHandlingObjectTypeDefinitionType.getVolatility();
+	}
 
 	//endregion
 

infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd

@@ -4362,6 +4362,22 @@
                     </xsd:documentation>
                 </xsd:annotation>
             </xsd:enumeration>
+            <xsd:enumeration value="explosive">
+                <xsd:annotation>
+                    <xsd:appinfo>
+                        <jaxb:typesafeEnumMember name="EXPLOSIVE"/>
+                    </xsd:appinfo>
+                    <xsd:documentation>
+                        The object can change in insane ways as a reaction to changes made by midPoint.
+                        E.g. the attribute that was modified by midPoint can be modified in a different way
+                        by the resource (this sometimes happen for nested groups). There is no way how to
+                        handle such a volatile behavior other than to re-read the account and re-run
+                        reconciliation after every change that midPoint does.
+                        This really brutal solution. It is quite inefficient. But it may be the only option
+                        to reliably manage data in some resources.
+                    </xsd:documentation>
+                </xsd:annotation>
+            </xsd:enumeration>
         </xsd:restriction>
     </xsd:simpleType>
 

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/controller/ModelController.java

@@ -581,6 +581,19 @@ public Collection<ObjectDeltaOperation<? extends ObjectType>> executeChanges(fin
 					for (LensProjectionContext projectionContext : context.getProjectionContexts()) {
 						executedDeltas.addAll(projectionContext.getExecutedDeltas());
 					}
+
+					if (context.hasExplosiveProjection()) {
+						PrismObject<? extends ObjectType> focus = context.getFocusContext().getObjectAny();
+
+						LOGGER.debug("Recomputing {} because there was explosive projection", focus);
+
+						LensContext<? extends ObjectType> recomputeContext = contextFactory.createRecomputeContext(focus, task, result);
+						recomputeContext.setDoReconciliationForAllProjections(true);
+						if (LOGGER.isTraceEnabled()) {
+							LOGGER.trace("Recomputing {}, context:\n{}", focus, recomputeContext.debugDump());
+						}
+						clockwork.run(recomputeContext, task, result);
+					}
 
 					cleanupOperationResult(result);
 
@@ -675,10 +688,12 @@ public <F extends ObjectType> void recompute(Class<F> type, String oid, Task tas
             Utils.clearRequestee(task);
 			PrismObject<F> focus = objectResolver.getObject(type, oid, null, task, result).asPrismContainer();
 
-			LOGGER.trace("Recomputing {}", focus);
+			LOGGER.debug("Recomputing {}", focus);
 
 			LensContext<F> syncContext = contextFactory.createRecomputeContext(focus, task, result); 
-			LOGGER.trace("Recomputing {}, context:\n{}", focus, syncContext.debugDump());
+			if (LOGGER.isTraceEnabled()) {
+				LOGGER.trace("Recomputing {}, context:\n{}", focus, syncContext.debugDump());
+			}
 			clockwork.run(syncContext, task, result);
 
 			result.computeStatus();

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/lens/LensContext.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2013 Evolveum
+ * Copyright (c) 2010-2017 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -1148,4 +1148,13 @@ public void addConflictingProjectionContext(LensProjectionContext conflictingCon
 	public void clearConflictingProjectionContexts() {
 		conflictingProjectionContexts.clear();
 	}
+
+	public boolean hasExplosiveProjection() throws SchemaException {
+		for (LensProjectionContext projectionContext: projectionContexts) {
+			if (projectionContext.getVolatility() == ResourceObjectVolatilityType.EXPLOSIVE) {
+				return true;
+			}
+		}
+		return false;
+	}
 }

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/lens/LensProjectionContext.java

@@ -1394,4 +1394,12 @@ public String getResourceOid() {
 			return null;
 		}
 	}
+
+	public ResourceObjectVolatilityType getVolatility() throws SchemaException {
+		RefinedObjectClassDefinition structuralObjectClassDefinition = getStructuralObjectClassDefinition();
+		if (structuralObjectClassDefinition == null) {
+			return null;
+		}
+		return structuralObjectClassDefinition.getVolatility();
+	}
 }

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/SynchronizationServiceImpl.java

@@ -294,7 +294,7 @@ public void notifyChange(ResourceObjectShadowChangeDescription change, Task task
 				}
 				subResult.recordSuccess();
 				eventInfo.record(task);
-				LOGGER.debug("SYNCHRONIZATION: DONE (dry run) for {}", object);
+				LOGGER.debug("SYNCHRONIZATION: DONE (dry run/unrelated) for {}", object);
 				return;
 			}
 

model/model-intest/src/test/java/com/evolveum/midpoint/model/intest/TestStrangeCases.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2010-2016 Evolveum
+ * Copyright (c) 2010-2017 Evolveum
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -139,7 +139,7 @@ public void initSystem(Task initTask, OperationResult initResult)
 			throws Exception {
 		super.initSystem(initTask, initResult);
 
-		initDummyResource(RESOURCE_DUMMY_CIRCUS_NAME, RESOURCE_DUMMY_CIRCUS_FILE, RESOURCE_DUMMY_CIRCUS_OID, null, initTask, initResult);
+		initDummyResource(RESOURCE_DUMMY_CIRCUS_NAME, RESOURCE_DUMMY_CIRCUS_FILE, RESOURCE_DUMMY_CIRCUS_OID, initTask, initResult);
 
 		dummyResourceCtlRed.addAccount(ACCOUNT_GUYBRUSH_DUMMY_USERNAME, "Guybrush Threepwood", "Monkey Island");