Optimizing ItemPath comparison a bit.

Evolveum · Jul 10, 2017 · f13727d · f13727d
1 parent 19474ba
commit f13727d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/infra/prism/src/main/java/com/evolveum/midpoint/prism/path/ItemPath.java b/infra/prism/src/main/java/com/evolveum/midpoint/prism/path/ItemPath.java
@@ -54,7 +54,7 @@ public Map<String, String> getNamespaceMap() {
 	}
 
 	public ItemPath() {
-		segments = new ArrayList<>(0);
+		segments = new ArrayList<>();
 	}
 
 	public ItemPath(QName... qnames) {

diff --git a/...del-impl/src/main/java/com/evolveum/midpoint/model/impl/controller/SchemaTransformer.java b/...del-impl/src/main/java/com/evolveum/midpoint/model/impl/controller/SchemaTransformer.java
@@ -170,7 +170,7 @@ public <O extends ObjectType> void applySchemasAndSecurity(PrismObject<O> object
     	try {
 	    	securityConstraints = securityEnforcer.compileSecurityConstraints(object, null);
 			if (LOGGER.isTraceEnabled()) {
-				LOGGER.trace("Security constrains for {}:\n{}", object, securityConstraints==null?"null":securityConstraints.debugDump());
+				LOGGER.trace("Security constraints for {}:\n{}", object, securityConstraints==null?"null":securityConstraints.debugDump());
 			}
 			if (securityConstraints == null) {
 				SecurityUtil.logSecurityDeny(object, "because no security constraints are defined (default deny)");
@@ -314,7 +314,7 @@ private <D extends ItemDefinition> void applySecurityConstraintsPhase(D itemDefi
 		AuthorizationDecisionType defaultAddDecision = securityConstraints.getActionDecision(ModelAuthorizationAction.ADD.getUrl(), phase);
 		AuthorizationDecisionType defaultModifyDecision = securityConstraints.getActionDecision(ModelAuthorizationAction.MODIFY.getUrl(), phase);
 		LOGGER.trace("applySecurityConstraints(itemDefs): def={}, phase={}, defaults R={}, A={}, M={}",
-				new Object[]{itemDefinition, phase, defaultReadDecision, defaultAddDecision, defaultModifyDecision});
+				itemDefinition, phase, defaultReadDecision, defaultAddDecision, defaultModifyDecision);
 		applySecurityConstraintsItemDef(itemDefinition, ItemPath.EMPTY_PATH, securityConstraints,
 				defaultReadDecision, defaultAddDecision, defaultModifyDecision, phase);
 

diff --git a/...urity-api/src/main/java/com/evolveum/midpoint/security/api/ObjectSecurityConstraints.java b/...urity-api/src/main/java/com/evolveum/midpoint/security/api/ObjectSecurityConstraints.java
@@ -22,10 +22,10 @@
 
 public interface ObjectSecurityConstraints extends DebugDumpable {
 
-	public AuthorizationDecisionType getActionDecision(String actionUrl, AuthorizationPhaseType phase);
+	AuthorizationDecisionType getActionDecision(String actionUrl, AuthorizationPhaseType phase);
 
-	public AuthorizationDecisionType findItemDecision(ItemPath itemPath, String actionUrl, AuthorizationPhaseType phase);
+	AuthorizationDecisionType findItemDecision(ItemPath itemPath, String actionUrl, AuthorizationPhaseType phase);
 
-	public boolean hasNoItemDecisions();
+	boolean hasNoItemDecisions();
 
 }