Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run admin-gui web pp with an embedded jetty #12

Merged
merged 1 commit into from Aug 30, 2016
Merged

Run admin-gui web pp with an embedded jetty #12

merged 1 commit into from Aug 30, 2016

Conversation

mmoayyed
Copy link
Contributor

  • Fix minor formatting issues in the pom
  • Let the admin gui (i.e midpoint.war) to be deployed via an embedded jetty instance. (Would have done the same for Tomcat, except tomcat plugins are terrible)

Basically, you'd do this:

cd midpoint/gui/admin-gui
mvn jetty:run-forked

Then go to localhost:8080/midpoint and login.

Don't ask developers to download a separate tomcat instance to test. More work for them :)

@mmoayyed
Copy link
Contributor Author

I may have to adjust indentations for myself. Are we using tabs or spaces?

@PetrGasparik
Copy link
Contributor

If I remember correctly, there is no such rule. Use your style.
Here is what we have: https://wiki.evolveum.com/display/midPoint/Development+Participation

@PetrGasparik
Copy link
Contributor

please fix the travis

@mederly
Copy link
Member

mederly commented Aug 28, 2016

Petr: About the tabs vs spaces: I think I've seen a guideline on this on wiki, but currently I cannot find it. (We don't have much of bureaucracy here ;))

But there is a template for Eclipse (https://github.com/Evolveum/midpoint/blob/master/config/eclipse/formatter-profile-midpoint.xml) we are more-or-less expected to use. It says that we use tabs at size of 4. (I know that in reality, some files are formatted also using spaces. I don't think it's a big problem.)

@mmoayyed
Copy link
Contributor Author

Cool. I double checked. Test failure appears to be unrelated to this patch. Seems to be a fluke in the integration tests?

@semancik
Copy link
Member

tabs vs spaces: tabs are preferred. But we are not whitespace nazis. It is OK to contribute with any indentation.

@semancik
Copy link
Member

Difficult to see what is the real problem with travis. The logs are truncated. Embededded jetty is a cool contribution and it seems unlikely that it can cause any major issue. So I'm going to merge this and explore manually on master.

@semancik semancik merged commit 37a7be9 into Evolveum:master Aug 30, 2016
@mmoayyed mmoayyed deleted the embedded-jetty branch October 27, 2016 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants