Bump dependency DocumentFormat.OpenXml to 3.0.1 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded DocumentFormat.OpenXml and SixLabors.ImageSharp to newer, non-breaking version ranges to ensure compatibility with recent features and improvements. Also introduced System.IO.Packaging dependency to enhance file manipulation capabilities within the OfficeIMO.Word project.
Modified the version constraints of `DocumentFormat.OpenXml` and `SixLabors.ImageSharp` in the project file to specify minimum and maximum versions. By defining an exclusive upper bound, this ensures compatibility and prevents unintentional upgrades to potentially breaking versions. The new ranges permit the latest non-major updates, maintaining access to recent fixes and optimizations while preserving API stability.
Removed unnecessary whitespace and replaced the Close method's implementation for proper resource disposal with _spreadSheetDocument.Dispose(). Enhanced readability in ExcelDocument.cs, easing future code maintenance. This change ensures that resources are released appropriately, averting potential memory leaks.
…breaks few things
… like how types are done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves following issues:
This PR allows usage of DocumentFormat.OpenXml in version 3.0.1 or higher. Due to changes require testing if everything works as expected. Would appreciate some feedback from real use cases.