Skip to content

Commit

Permalink
get_fields bug
Browse files Browse the repository at this point in the history
check if fiels from properties are not on keys(header)
  • Loading branch information
Carles Boils Gisbert committed Apr 7, 2017
1 parent 423436e commit 28ac61d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
8 changes: 5 additions & 3 deletions geokey_export/renderers.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,13 @@ def render_comments(self, data):

def render_contribution(self, data):
"""Create the csv file all the contributions."""
prop_keys = get_fields(data)
keys.extend(prop_keys)
keys_obs = keys
prop_keys = get_fields(data, keys_obs)
keys_obs.extend(prop_keys)

all_csv_rows = [';'.join(keys)]
for i in range(len(data)):
all_csv_rows.append(create_observation_row(data[i], keys))
all_csv_rows.append(create_observation_row(data[i], keys_obs))

return '\n'.join(all_csv_rows)

Expand Down
5 changes: 3 additions & 2 deletions geokey_export/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,17 @@ def get_responses(obs_id, comment, length):
return responses


def get_fields(data):
def get_fields(data, keys):
"""Create list of all the existing fields for this observation."""
keys_fields = []
for i in range(len(data)):
if data[i]['properties']:
properties = data[i]['properties']
fields = [prop_keys for prop_keys in properties.iterkeys()]
for field in fields:
if field not in keys_fields:
if field not in keys:
keys_fields.append(field)

return keys_fields


Expand Down

0 comments on commit 28ac61d

Please sign in to comment.