mstevens-0.5.0 #18
Merged
mstevens-0.5.0 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the massive all in one commit) Fixes issues #4, #6, #7, #13, #14, #15, #16 & #17; as well as a few other (potential) problems I didn't bother to create issues for. The main fundamental change it geokey_sapelli now uses the actual Sapellli java code for the complete process of loading and parsing Sapelli projects from SAP files (issue #17). This requires this JAR file: https://github.com/ExCiteS/Sapelli/releases/tag/v2.0.0-beta-16.5 Using the Java code for project loading/parsing has several advantages. It means we no longer have to maintain a separate Python implementation of the Sapelli XML format parser. This resolves a number of known issues (such as #6 and #7) and also makes it easier to add support for new or existing Sapelli features to geokey-sapelli. Signed-off-by: Matthias Stevens <matthias.stevens@gmail.com>
mstevens83
changed the title
…ier debugging) Signed-off-by: Matthias Stevens <matthias.stevens@gmail.com>
- path to JAR file was somehow incorrect all of a sudden (perhaps due changes in travis infrastructure) - the Sapelli JAR is now automatically downloaded from https://github.com/ExCiteS/Sapelli/releases/... (edit .travis.yml to change the version which is being used) - travis now install & uses oracle-java8 Signed-off-by: Matthias Stevens <matthias.stevens@gmail.com>
mstevens83
force-pushed
the
mstevens-0.5.0
branch
from
9bdadbf
to
80bee48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #4, #6, #7, #13, #14, #15, #16 & #17; as well as a few other (potential) problems I didn't bother to create issues for.
The main fundamental change it geokey_sapelli now uses the actual Sapellli java code for the complete process of loading and parsing Sapelli projects from SAP files (issue #17).
This requires this JAR file: https://github.com/ExCiteS/Sapelli/releases/tag/v2.0.0-beta-16.5
Using the Java code for project loading/parsing has several advantages. It means we no longer have to maintain a separate Python implementation of the Sapelli XML format parser. This resolves a number of known issues (such as #6 and #7) and also makes it easier to add support for new or existing Sapelli features to geokey-sapelli.
Signed-off-by: Matthias Stevens matthias.stevens@gmail.com