-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String.to_existing_atom failing in utils.ex #88
Comments
def pool_name(name) do
String.to_existing_atom("hammer_backend_#{name}_pool")
end @epinault is there a reason why this needs to be |
I think it s to avoid some risk of Atom during configuration but we can make it to_atom for now if you open an MR https://hexdocs.pm/credo/Credo.Check.Warning.UnsafeToAtom.html |
@epinault a fix for this has been added to PR #87 Edit: Re: the IMHO we have a use case in Hammer where Also, the credo check itself is tagged from the credo link: ![]() |
+1 also need this, can't deploy new project without it. 🙏🏼 |
Hello, I am have released a new version 6.2.1. I am unfortunately traveling for another few days and have limited access so hopefully that will unblock you |
Thank you @epinault !!! 🙏 that solved it for me |
Describe the bug
When calling Hammer functions with a single backend, NOT a list of backends, the call fails with:
** Provide the following details
Expected behavior
I expect
Hammer.check_rate/4
to not result in an errorActual behavior
See above
The text was updated successfully, but these errors were encountered: