Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are "Named Individuals" included by mistake? #52

Open
paulmillar opened this issue Jun 14, 2022 · 4 comments · May be fixed by #65
Open

Are "Named Individuals" included by mistake? #52

paulmillar opened this issue Jun 14, 2022 · 4 comments · May be fixed by #65
Assignees
Labels
bug Something isn't working vote required Issues that required a vote

Comments

@paulmillar
Copy link

The ontology description page shows the ontology has various "Named Individuals".

These individuals appear to be ad hoc and poorly defined.

Also, the PaNET methodology deliverable DOI does not define any Named Individuals.

These individuals might be intended as examples. If so, I think they should be moved outside of the PaNET ontology -- as they may cause confusion if included in the main ontology.

@spc93
Copy link
Collaborator

spc93 commented Jun 14, 2022 via email

@spc93
Copy link
Collaborator

spc93 commented Aug 4, 2022

Happy to remove individuals. Any objections?

@paulmillar
Copy link
Author

My suggestion is:

  1. create a concrete change, in the form of a pull-request,
  2. ask for feedback / review from others to verify the pull-request,
  3. accept the pull-request (or, perhaps Alejandra does this?)

You can include some keywords in the commit to automatically close this issue once the pull request is accepted.

(Just give me a shout if you'd like more info on the more mechanical parts.)

HTH,
Paul.

@agbeltran
Copy link
Member

I agree that those named individuals should be removed - if we want to keep the examples, we should have them in a separate file (separating Tbox and Abox)

@agbeltran agbeltran added the bug Something isn't working label Aug 17, 2022
@agbeltran agbeltran linked a pull request Sep 14, 2022 that will close this issue
@agbeltran agbeltran linked a pull request Sep 14, 2022 that will close this issue
@agbeltran agbeltran added this to the Next release milestone Sep 15, 2022
@agbeltran agbeltran self-assigned this Sep 15, 2022
@agbeltran agbeltran added the vote required Issues that required a vote label Oct 13, 2022
@K-Syder K-Syder removed this from the Next release milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vote required Issues that required a vote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants