Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"attribute" doesn't work in multiple lines #214

Closed
a16 opened this issue Jan 15, 2015 · 2 comments
Closed

"attribute" doesn't work in multiple lines #214

a16 opened this issue Jan 15, 2015 · 2 comments

Comments

@a16
Copy link

a16 commented Jan 15, 2015

Hi,

"attribute"(Generic attribute) works fine in single line, but it doesn't work in multiple lines.
Is this intentional? If not, I'll send a PR.

I guess it's a piece of cake...

diff --git a/lib/exabgp/configuration/ancient.py b/lib/exabgp/configuration/ancient.py
index 1c75eea..06e4ef4 100644
--- a/lib/exabgp/configuration/ancient.py
+++ b/lib/exabgp/configuration/ancient.py
@@ -1658,7 +1658,7 @@ class Configuration (object):
                                        'local-preference','atomic-aggregate','aggregator',
                                        'path-information','community','originator-id','cluster-list',
                                        'extended-community','split','label','rd','route-distinguisher',
-                                       'watchdog','withdraw'
+                                       'watchdog','withdraw','attribute'
                                ]
                        )
                        if r is False: return False
@thomas-mangin
Copy link
Member

well spotted ! could you please send me a PR, please also update the CHANGELOG file to provide attribution, I will merge

@thomas-mangin
Copy link
Member

Merged - thank you for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants