Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 release date ? #598

Closed
thomas-mangin opened this issue Apr 6, 2017 · 10 comments
Closed

4.0.0 release date ? #598

thomas-mangin opened this issue Apr 6, 2017 · 10 comments
Milestone

Comments

@thomas-mangin
Copy link
Member

Hello,

The only change holding back the release of ExaBGP 4.0.0 is python3 support (lots was already done by @tmmorin with six).

It seems that the big'gy will be the conversion of all the string used for encoding / decoding into b"" string.

Once this is completed, I am "happy" to release. Help welcomed !

@thomas-mangin thomas-mangin added this to the 4.0 milestone Apr 6, 2017
@tmmorin
Copy link
Contributor

tmmorin commented Apr 7, 2017

Do you have a process on which we could iterate ?
(test with py3, fix an issue, validate with py2/py3, rince & repeat...)

@thomas-mangin
Copy link
Member Author

@tmmorin: sounds like the plan 😃

@tmmorin
Copy link
Contributor

tmmorin commented Apr 7, 2017

Yes, but the existing unit test suite does already pass with python3.
What do you suggest running to test the rest ?

(the other plan would be: run 2to3, but not to modify the source, which would become non-python2 compatible, but to see all the places that can be changed for python3. But filtering all the suggested changes, to keep only the ones that are strictly needed, is cumbersome...)

@thomas-mangin
Copy link
Member Author

When I ran the code "by hand" it fails so I assume the test suite is broken ... again ...

@tmmorin
Copy link
Contributor

tmmorin commented May 8, 2017

In fact, the only test suite I had been running for the initial python3 work was qa/tests/*.py

I've now a work branch in my repo which is passing much more tests from qa/bin.
I still have issues running some qa/bin/conversation tests, but there are issues with py2 as well as py3.

@thomas-mangin
Copy link
Member Author

@tmmorin do you want to share/merge your branch - so I can make sure that any regression in the test suite is fixed in both p2 and p3 please ?

@tmmorin
Copy link
Contributor

tmmorin commented May 9, 2017

I had a few more things to merge first, but now here is the branch:
https://github.com/tmmorin/exabgp/tree/py3

some more tests pass with my proposed fix for #613, but not all of them

@tmmorin
Copy link
Contributor

tmmorin commented May 10, 2017

the whole test suite (except qa/bin/conversation tests that seem hard to pass in python2 as well) seem to be happy with python3

anything else missing for releasing a 4.0.0beta ?

@thomas-mangin
Copy link
Member Author

thomas-mangin commented May 10, 2017

I need to change a few things ( version reported for JSON and TEXT interface ), but I should be able to release in the next few days.
Let me just go through all the issues to make sure all is good.

@thomas-mangin
Copy link
Member Author

4.0.0 was released !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants