Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin typeguard version to 2.xx. #363

Merged
merged 3 commits into from Mar 16, 2023
Merged

Pin typeguard version to 2.xx. #363

merged 3 commits into from Mar 16, 2023

Conversation

hategan
Copy link
Collaborator

@hategan hategan commented Mar 15, 2023

Also pins filelock and psutil to known working major versions.

Fixes #362

Also pins filelock and psutil to known working major versions.
@hategan
Copy link
Collaborator Author

hategan commented Mar 16, 2023

I'm merging this without review as an emergency measure because, without it, the code is mostly unusable and because actions, such as web site deployment, fail.

@hategan hategan merged commit f7fb8c3 into main Mar 16, 2023
@hategan hategan deleted the pin_typeguard_version branch March 16, 2023 17:11
@hategan
Copy link
Collaborator Author

hategan commented Mar 16, 2023

A second set of eyes would still be useful here though.

Copy link
Collaborator

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack on the pin for typeguard. I also don't mind the version pin on filelock and psutil, but what is the rationale? Do you consider pinned versions more reliable / reproducible / stable in general?

@hategan
Copy link
Collaborator Author

hategan commented Mar 17, 2023

Ack on the pin for typeguard. I also don't mind the version pin on filelock and psutil, but what is the rationale? Do you consider pinned versions more reliable / reproducible / stable in general?

I'm trying to avoid the same problem happening in the future with filelock and psutil and I think "compatible version" (i.e. ~=) is a reasonable solution that still allows security/stability updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeguard 3.0 removes check_argument_types
2 participants