-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/sof 5945 #83
Chore/sof 5945 #83
Conversation
@@ -0,0 +1,93 @@ | |||
name: espresso |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a YAML linter for the PRs pls, @chu-k already added for https://github.com/Exabyte-io/python_code/blob/main/.github/workflows/cicd.yml
applications/espresso.yml
Outdated
- version: "6.7.0" | ||
isDefault: true | ||
hasAdvancedComputeOptions: true | ||
# version 6.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe #### version 6.8.0 ####
or something like that to make it more pronounced
src/js/data/application_data.js
Outdated
@@ -0,0 +1,142 @@ | |||
// eslint-disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's minimize the autogenerated files, pls
.github/workflows/cicd.yml
Outdated
with: | ||
repository: Exabyte-io/actions | ||
token: ${{ secrets.BOT_GITHUB_TOKEN }} | ||
ref: 4d3e0fc415f6eb28739a331e7f44cd7ba242668f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be omitted, actions PR is merged now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This PR concerns: